Fix for CGAL Error#319
Open
jeroenrnl wants to merge 1 commit into
Open
Conversation
Fixes the following error when running recent OpenSCAD versions ``` WARNING: CGAL error in CGAL_Nef_polyhedron3(): CGAL ERROR: assertion violation! Expr: e_below != SHalfedge_handle() File: /usr/include/CGAL/Nef_3/SNC_FM_decorator.h Line: 418. Attempting union... WARNING: CGALUtils::convertSurfaceMeshToNef: Discarded 80 facets during Nef conversion. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error when running recent OpenSCAD versions
Now the tests.py runs with the git version of OpenSCAD, with only
offset.scadandround.scadfailing with the errorThis is openscad/openscad#6083 / openscad/openscad#5862
and these are only warnings, the actual result still works.
If I temporary sabotage
openscad.pyandbom.pyto not fail on warnings, the tests run and the resulting png is virtually identical to the ones currently in git.