Check peripheral identity to avoid using a stale instance#156
Merged
Conversation
|
Glad to see this making it to a PR, thank you! I believe it also needs updated in the retrieval functions as well? See: 1ba8c1f |
Contributor
Author
No, that filter does not exist anymore, all peripherals are updated unconditionally, so no changes should be needed there. |
Contributor
|
Released in 1.0.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is proposed fix for #155.
This just checks if the cached CBMPeripheralNative has the same CBPeripheral object and updates the cache if the peripheral has changed.