Merge branch 'release/0.9.1'

Author: arcticicestudio

CHANGELOG.md

@@ -4,6 +4,16 @@
 
 ---
 
+# 0.9.1
+*2017-04-14*
+## Improvements
+### Theme Settings
+❯ Removed a unnecessary IO write event when when deactivating the package. Before all theme settings have been written out to the store file `theme-settings-store.less`. The `deactivation()` method has been removed since there is currently no need to handle a package deactivation event. (@arcticicestudio, #49, 892e6735)
+
+## Bug Fixes
+### Theme Settings
+❯ Fixed a "Undefined variable" exception when deactivating the package. This was caused by the wrongly named `@theme-setting-custom-comment-contrast` variable which must be named `@theme-setting-accessibility-custom-comment-contrast`. (@arcticicestudio, #48, c5af4e3e)
+
 # 0.9.0
 *2017-04-14*
 ## Features

README.md

@@ -49,7 +49,7 @@ Detailed descriptions for supported languages can be found in the [project wiki]
 ![][scrot-lang-xml]
 
 ## Development
-[![](https://img.shields.io/badge/Changelog-0.9.0-81A1C1.svg)](https://github.com/arcticicestudio/nord-atom-syntax/blob/v0.9.0/CHANGELOG.md) [![](https://img.shields.io/badge/Workflow-gitflow--branching--model-81A1C1.svg)](http://nvie.com/posts/a-successful-git-branching-model) [![](https://img.shields.io/badge/Versioning-ArcVer_0.8.0-81A1C1.svg)](https://github.com/arcticicestudio/arcver)
+[![](https://img.shields.io/badge/Changelog-0.9.1-81A1C1.svg)](https://github.com/arcticicestudio/nord-atom-syntax/blob/v0.9.1/CHANGELOG.md) [![](https://img.shields.io/badge/Workflow-gitflow--branching--model-81A1C1.svg)](http://nvie.com/posts/a-successful-git-branching-model) [![](https://img.shields.io/badge/Versioning-ArcVer_0.8.0-81A1C1.svg)](https://github.com/arcticicestudio/arcver)
 
 ### Contribution
 Please report issues/bugs, feature requests and suggestions for improvements to the [issue tracker](https://github.com/arcticicestudio/nord-atom-syntax/issues).

index.less

@@ -2,7 +2,7 @@
 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 title      Index                                               +
 project    nord-atom-syntax                                    +
-version    0.9.0                                               +
+version    0.9.1                                               +
 repository https://github.com/arcticicestudio/nord-atom-syntax +
 author     Arctic Ice Studio                                   +
 email      development@arcticicestudio.com                     +

lib/main.js

@@ -16,14 +16,13 @@ import { toggleClass } from "./utils";
 export default {
   writeConfig(options) {
     let customCommentContrast = atom.config.get("nord-atom-syntax.accessibility.commentContrast");
-    let config = `@theme-setting-custom-comment-contrast: ${customCommentContrast}%;\n`;
+    let config = `@theme-setting-accessibility-custom-comment-contrast: ${customCommentContrast}%;\n`;
 
     fs.writeFile(`${__dirname}/../styles/theme-settings-store.less`, config, "utf8", () => {
       if (!options || !options.noReload) {
         let themePack = atom.packages.getLoadedPackage("nord-atom-syntax");
 
         if (themePack) {
-          themePack.deactivate();
           setImmediate(() => themePack.activate());
         }
       }
@@ -36,10 +35,5 @@ export default {
   activate() {
     toggleClass(true, "theme-nord-atom-syntax-accessibility-custom-comment-contrast");
     atom.config.onDidChange("nord-atom-syntax.accessibility.commentContrast", () =>this.writeConfig({ noReload: true }));
-  },
-
-  deactivate() {
-    toggleClass(false, "theme-nord-atom-syntax-accessibility-custom-comment-contrast");
-    this.writeConfig({ noReload: true });
   }
 };

package.json

@@ -1,7 +1,7 @@
 {
   "name": "nord-atom-syntax",
   "theme": "syntax",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "An arctic, north-bluish clean and elegant Atom syntax theme.",
   "author": {
     "name": "Arctic Ice Studio",

styles/syntax-theme-settings.less

@@ -14,16 +14,16 @@ copyright  Copyright (C) 2017                                  +
 /*+--- Custom Comment Contrast ---+*/
 .theme-@{syntax-theme-name}-accessibility-custom-comment-contrast {
   .syntax--comment {
-    color: lighten(@syntax-color-comment, @theme-setting-custom-comment-contrast);
+    color: lighten(@syntax-color-comment, @theme-setting-accessibility-custom-comment-contrast);
 
     .syntax--markup.syntax--link {
-      color: lighten(@syntax-color-comment, @theme-setting-custom-comment-contrast);
+      color: lighten(@syntax-color-comment, @theme-setting-accessibility-custom-comment-contrast);
     }
   }
 
   .syntax--punctuation {
     &.syntax--comment {
-      color: lighten(@syntax-color-comment, @theme-setting-custom-comment-contrast);
+      color: lighten(@syntax-color-comment, @theme-setting-accessibility-custom-comment-contrast);
     }
   }
 }

styles/theme-settings-store.less

@@ -1 +1 @@
-@theme-setting-custom-comment-contrast: 0%;
+@theme-setting-accessibility-custom-comment-contrast: 0%;