Skip to content

Commit 8980d39

Browse files
Merge branch 'release/0.8.0'
2 parents b439460 + b07f783 commit 8980d39

5 files changed

Lines changed: 153 additions & 21 deletions

File tree

CHANGELOG.md

Lines changed: 117 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,107 @@
44

55
<!--lint disable no-duplicate-headings-->
66

7+
# 0.8.0
8+
9+
![Release Date: 2019-04-11](https://img.shields.io/badge/Release_Date-2019--04--11-88C0D0.svg?style=flat-square) [![Project Board](https://img.shields.io/badge/Project_Board-0.8.0-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/15) [![Milestone](https://img.shields.io/badge/Milestone-0.8.0-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/12)
10+
11+
## Features
12+
13+
### UI
14+
15+
**Background color of inactive keyboard focused list items**#107#116 (⊶ 3e35efb9) by [@octref][gh-user-octref]
16+
↠ Added support for `list.inactiveFocusBackground` theme key used for the background color of the selected item when navigating the file explorer list with the keyboard and moving the focus to another UI component (like the editor).
17+
It has been set to `nord2` with a opacity of 80% to match the style of inactive list items that were focused without the keyboard (`list.inactiveSelectionBackground`).
18+
19+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54876811-74f57080-4e16-11e9-9a21-119837740a33.png" /></p>
20+
21+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54876810-74f57080-4e16-11e9-94f2-32b641288b54.png" /></p>
22+
23+
## Improvements
24+
25+
### Syntax
26+
27+
**Perl sigils same color as variables**#67 (⊶ 698d9bae) by [@marcusramberg][gh-user-marcusramberg]
28+
↠ To ensure a consistent highlighting Perl _Sigils_ are now also colorized like variables since they are actually part of the variable. They are now less distracting by using the same color like the variable itself instead of handling them as prefixed characters or a keyword.
29+
30+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54866393-82a5ea00-4d73-11e9-98d6-b90db34b3fd2.png" /></p>
31+
32+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54866400-905b6f80-4d73-11e9-97fa-c5433ba1a98c.png" /></p>
33+
34+
**Correct colors for JavaScript objects**#115 / #97 (⊶ b0c399cd) by [@samchamberland][gh-user-samchamberland]
35+
↠ Previously JavaScript objects colorized with `nord7` caused by a superfluous definition of the `meta.var.expr` scope selector. This has been changed. This has been changed to correctly use `nord4` for variables.
36+
37+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54870063-f7901880-4da1-11e9-9860-6d8116b6c8c5.png" /></p>
38+
39+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54870062-f7901880-4da1-11e9-9ff4-43737783c1df.png" /></p>
40+
41+
**Better function parameter highlighting in Python**#108#113 (⊶ 840b36c3) by [@Al2Me6][gh-user-al2me6]
42+
↠ Previously the highlighting for function parameters in Python were colorized with the same color like the function itself (`nord8`) instead of `nord4`. This has been improved by removing the too generic scope `meta.function-call` from the `source.python` scope.
43+
44+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54865125-17ebb300-4d61-11e9-8f59-1f5c37795195.png" /></p>
45+
46+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54865128-23d77500-4d61-11e9-8c67-3acff0ed487f.png" /></p>
47+
48+
**Improved interpolated string literals**#106#114 (⊶ e13ded12) by [@varog-norman][gh-user-varog-norman]
49+
↠ Improved the color for function braces in string templates to use `nord6` instead of `nord14`. Begin and end characters of an interpolated string literal `${}` are now also colorized as keyword (`nord9`) for better visual distinction.
50+
51+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54867234-298f8380-4d7e-11e9-820f-244cfaf65b92.png" /></p>
52+
53+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54867233-28f6ed00-4d7e-11e9-9a65-ef12a61203f9.png" /></p>
54+
55+
**Comment Color Brightness**#117/#14/#72#118 (⊶ 7e3881b6)
56+
↠ Implemented the frequently requested and long-time outstanding increase of the comment color (`nord3`) brightness by 10% from a lightness level of ~35% to ~45%.
57+
58+
**Please see [arcticicestudio/nord#94][gh-nord#94] for all details about this design change decision**!
59+
60+
For users who would like to use the previously used coloring VS Code allows to [customize and override styles of a specific theme][vscode-docs-color-theme-customize] through the user settings. To override the highlighting color of comments **only for Nord** the following snippet can be added to the settings (JSON) file:
61+
62+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54902736-76886c80-4eda-11e9-86cd-dfc935aff5e3.png" /></p>
63+
64+
<p align="center"><img src="https://user-images.githubusercontent.com/7836623/54902735-76886c80-4eda-11e9-9aa0-41ded647bdb2.png" /></p>
65+
66+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54902766-856f1f00-4eda-11e9-897a-9b0971586a0b.png" /></p>
67+
68+
<p align="center"><img src="https://user-images.githubusercontent.com/7836623/54902765-856f1f00-4eda-11e9-9d09-50c89faece43.png" /></p>
69+
70+
```json
71+
"editor.tokenColorCustomizations": {
72+
"[Nord]": {
73+
"comments": "#4C566A"
74+
}
75+
}
76+
```
77+
78+
Please see the official documentation about [user and workspace settings][vscode-docs-settings] for more details how to customize and configure VS Code.
79+
80+
### UI
81+
82+
**Decreased opacity for peek view match highlighting**#99#112 (⊶ 7d9547ea) by [@octref][gh-user-octref]
83+
↠ Previously the opacity for peek view match highlighting was too bright that made it almost impossible to read the underlying text. This has been improved by decreasing the opacity of the used color (`nord8`) to 30%.
84+
85+
<p align="center"><strong>Before</strong><br /><img src="https://user-images.githubusercontent.com/4033249/44305931-3e63ee80-a339-11e8-91e3-ad40ccbbe98e.png" /></p>
86+
87+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54864866-76af2d80-4d5d-11e9-9800-37fb5c7e10dc.png" /></p>
88+
89+
**Cleaner Git diff view highlighting**#105 (⊶ 63fa7d9e) by [@danfo][gh-user-danfo]
90+
91+
Previously the Git diff view used `nord14` with a opacity of 30% to highlight added/modified elements causing some syntax elements like comments to be bad readable. This has now been changed to use `nord9` with a opacity of 20% instead to ensure a better readability and general clearer visual appearance. Also the previously used theme keys `diffEditor.insertedTextBorder` and `diffEditor.removedTextBorder` have been removed for a more clutter-free style.
92+
93+
<p align="center"><strong>Before</strong><br /><img src="https://raw.githubusercontent.com/arcticicestudio/nord-visual-studio-code/develop/assets/scrot-feature-ui-diffeditor-inserted.png" /></p>
94+
95+
<p align="center"><img src="https://raw.githubusercontent.com/arcticicestudio/nord-visual-studio-code/develop/assets/scrot-feature-ui-diffeditor-removed.png" /></p>
96+
97+
<p align="center"><strong>After</strong><br /><img src="https://user-images.githubusercontent.com/7836623/54881878-f53ac680-4e54-11e9-8b84-e27e13b5dd34.png" /></p>
98+
99+
There is still a lot of potential to improve the highlighting for Git diff views. The feature request [Microsoft/vscode#71663][gh-microsoft/vscode#71663] has been requested from the VS Code team to allow theme authors to improve the styles of syntax elements within Git diff scopes which would solve the problem of unreadable elements.
100+
101+
## Bug Fixes
102+
103+
### UI
104+
105+
**Tabs in split views can not be dragged and moved**#98#104 (⊶ 924c1901) by [@mdogadailo][gh-user-mdogadailo] and [@sdr0x07b6][gh-user-sdr0x07b6]
106+
↠ Previously the `editorGroup.border` theme key used a transparent color that caused tabs in split views to not being moveable anymore since the underlying logic removes some requires CSS classes. This has been fixed by to a opacity of 1% to fix the tab usage while still keeping the theme ambience (almost invisible for the human eye).
107+
7108
# 0.7.1
8109

9110
![Release Date: 2019-03-22](https://img.shields.io/badge/Release_Date-2019--03--22-88C0D0.svg?style=flat-square) [![Project Board](https://img.shields.io/badge/Project_Board-0.7.1-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/projects/14) [![Milestone](https://img.shields.io/badge/Milestone-0.7.1-88C0D0.svg?style=flat-square)](https://github.com/arcticicestudio/nord-visual-studio-code/milestone/11)
@@ -154,7 +255,7 @@ All currently implemented Gulp tasks have therefore been migrated to npm scripts
154255

155256
### UI
156257

157-
❯ Added new [new theming color keys][vscode-relnote-1.16-theme-improv] for highlighting the [overview ruler][vscode-color-ref-editor-colors] introduced in Visual Studio Code version 1.16. (#45 in PR #48, @arcticicestudio, 0459527b)
258+
❯ Added new [new theming color keys][vscode-relnote-1.16-theme-improv] for highlighting the [overview ruler][vscode-docs-color-ref-editor-colors] introduced in Visual Studio Code version 1.16. (#45 in PR #48, @arcticicestudio, 0459527b)
158259

159260
<p align="center"><strong>Status Highlighting</strong><br><img src="https://user-images.githubusercontent.com/7836623/30780022-9c9b7ea4-a101-11e7-92ca-f786106469f3.png"/><br><strong>Word Highlighting</strong><br><img src="https://user-images.githubusercontent.com/7836623/30780023-9edf84c6-a101-11e7-8be7-8415b111327f.png"/></p>
160261

@@ -514,8 +615,10 @@ Detailed information about features, supported languages and install instruction
514615
[prettier]: https://prettier.io
515616
[typescript]: https://www.typescriptlang.org
516617
[vsce]: https://github.com/Microsoft/vscode-vsce
517-
[vscode-color-ref-editor-colors]: https://code.visualstudio.com/docs/getstarted/theme-color-reference#_editor-colors
518618
[vscode-docs-approved-badges]: https://code.visualstudio.com/docs/extensionAPI/extension-manifest#_approved-badges
619+
[vscode-docs-color-ref-editor-colors]: https://code.visualstudio.com/docs/getstarted/theme-color-reference#_editor-colors
620+
[vscode-docs-color-theme-customize]: https://code.visualstudio.com/docs/getstarted/themes#_customizing-a-color-theme
621+
[vscode-docs-settings]: https://code.visualstudio.com/docs/getstarted/settings
519622
[vscode-docs-theme-git-colors]: https://code.visualstudio.com/docs/getstarted/theme-color-reference#_git-colors
520623
[vscode-docs-vscodeignore]: https://code.visualstudio.com/docs/extensions/publish-extension#_vscodeignore
521624
[vscode-relnote-1.14-extension-authoring]: https://code.visualstudio.com/updates/v1_14#_extension-authoring
@@ -538,3 +641,15 @@ Detailed information about features, supported languages and install instruction
538641
[vsc-rln-1.24-thc]: https://code.visualstudio.com/updates/v1_24#_new-theme-colors
539642
[vsc-rln-1.24]: https://code.visualstudio.com/updates/v1_24
540643
[vscode#178]: https://github.com/Microsoft/vscode/issues/178
644+
645+
<!--v 0.8.0 -->
646+
647+
[gh-microsoft/vscode#71663]: https://github.com/Microsoft/vscode/issues/71663
648+
[gh-nord#94]: https://github.com/arcticicestudio/nord/issues/94
649+
[gh-user-al2me6]: https://github.com/al2Me6
650+
[gh-user-danfo]: https://github.com/danfo
651+
[gh-user-marcusramberg]: https://github.com/marcusramberg
652+
[gh-user-mdogadailo]: https://github.com/mdogadailo
653+
[gh-user-samchamberland]: https://github.com/samchamberland
654+
[gh-user-sdr0x07b6]: https://github.com/sdr0x07b6
655+
[gh-user-varog-norman]: https://github.com/varog-norman

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<p align="center"><img src="https://cdn.travis-ci.org/images/favicon-c566132d45ab1a9bcae64d8d90e4378a.svg" width=24 height=24/> <a href="https://travis-ci.org/arcticicestudio/nord-visual-studio-code"><img src="https://img.shields.io/travis/arcticicestudio/nord-visual-studio-code/develop.svg?style=flat-square"/></a> <img src="https://circleci.com/favicon.ico" width=24 height=24/> <a href="https://circleci.com/gh/arcticicestudio/nord-visual-studio-code"><img src="https://img.shields.io/circleci/project/github/arcticicestudio/nord-visual-studio-code/develop.svg?style=flat-square"/></a> <img src="https://assets-cdn.github.com/favicon.ico" width=24 height=24/> <a href="https://github.com/arcticicestudio/nord-visual-studio-code/releases/latest"><img src="https://img.shields.io/github/release/arcticicestudio/nord-visual-studio-code.svg?style=flat-square"/></a> <a href="https://github.com/arcticicestudio/nord/releases/tag/v0.2.0"><img src="https://img.shields.io/badge/Nord-v0.2.0-88C0D0.svg?style=flat-square"/></a> <img src="https://marketplace.visualstudio.com/favicon.ico" width=24 height=24/> <a href="https://code.visualstudio.com/updates/v1_12"><img src="https://img.shields.io/badge/VS_Code-v1.12+-373277.svg?style=flat-square"/></a> <a href="https://marketplace.visualstudio.com/items/arcticicestudio.nord-visual-studio-code"><img src="https://vsmarketplacebadge.apphb.com/version/arcticicestudio.nord-visual-studio-code.svg?style=flat-square"/></a> <a href="https://marketplace.visualstudio.com/items/arcticicestudio.nord-visual-studio-code"><img src="https://vsmarketplacebadge.apphb.com/installs/arcticicestudio.nord-visual-studio-code.svg?style=flat-square"/></a> <a href="https://marketplace.visualstudio.com/items/arcticicestudio.nord-visual-studio-code"><img src="https://vsmarketplacebadge.apphb.com/rating-short/arcticicestudio.nord-visual-studio-code.svg?style=flat-square"/></a></p>
44

5-
<p align="center"><a href="https://github.com/arcticicestudio/nord-visual-studio-code/blob/v0.7.1/CHANGELOG.md#070"><img src="https://img.shields.io/badge/Changelog-0.7.1-81A1C1.svg?style=flat-square"/></a></p>
5+
<p align="center"><a href="https://github.com/arcticicestudio/nord-visual-studio-code/blob/v0.8.0/CHANGELOG.md#070"><img src="https://img.shields.io/badge/Changelog-0.8.0-81A1C1.svg?style=flat-square"/></a></p>
66

77
<p align="center">An arctic, north-bluish clean and elegant <a href="https://code.visualstudio.com">Visual Studio Code</a> theme.</p>
88

@@ -33,10 +33,10 @@ ext install arcticicestudio.nord-visual-studio-code
3333

3434
#### <img src="https://marketplace.visualstudio.com/favicon.ico" width=16 height=16/> [Packaged VSIX Extension](https://code.visualstudio.com/docs/extensions/install-extension#_install-from-a-vsix)
3535

36-
[Download](https://github.com/arcticicestudio/nord-visual-studio-code/releases/latest) the latest [`nord-visual-studio-code-0.7.1.vsix`](https://github.com/arcticicestudio/nord-visual-studio-code/releases/download/v0.7.1/nord-visual-studio-code-0.7.1.vsix) file from the GitHub repository and install it from the command line
36+
[Download](https://github.com/arcticicestudio/nord-visual-studio-code/releases/latest) the latest [`nord-visual-studio-code-0.8.0.vsix`](https://github.com/arcticicestudio/nord-visual-studio-code/releases/download/v0.8.0/nord-visual-studio-code-0.8.0.vsix) file from the GitHub repository and install it from the command line
3737

3838
```shell
39-
code --install-extension nord-visual-studio-code-0.7.1.vsix
39+
code --install-extension nord-visual-studio-code-0.8.0.vsix
4040
```
4141

4242
or from within VS Code by launching _Quick Open_ and running the _Install from VSIX..._ command.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nord-visual-studio-code",
33
"displayName": "Nord",
44
"description": "An arctic, north-bluish clean and elegant Visual Studio Code theme.",
5-
"version": "0.7.1",
5+
"version": "0.8.0",
66
"publisher": "arcticicestudio",
77
"author": {
88
"name": "Arctic Ice Studio",

themes/nord.json

Lines changed: 31 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@
1717
"debugExceptionWidget.background": "#4c566a",
1818
"debugExceptionWidget.border": "#2e3440",
1919
"debugToolBar.background": "#3b4252",
20-
"diffEditor.insertedTextBackground": "#a3be8c4d",
21-
"diffEditor.insertedTextBorder": "#a3be8c4d",
20+
"diffEditor.insertedTextBackground": "#81a1c133",
2221
"diffEditor.removedTextBackground": "#bf616a4d",
23-
"diffEditor.removedTextBorder": "#bf616a4d",
2422
"dropdown.background": "#3b4252",
2523
"dropdown.border": "#3b4252",
2624
"dropdown.foreground": "#d8dee9",
@@ -56,7 +54,7 @@
5654
"editorBracketMatch.border": "#88c0d0",
5755
"editorCodeLens.foreground": "#4c566a",
5856
"editorGroup.background": "#2e3440",
59-
"editorGroup.border": "#3b425200",
57+
"editorGroup.border": "#3b425201",
6058
"editorGroup.dropBackground": "#3b425299",
6159
"editorGroupHeader.noTabsBackground": "#2e3440",
6260
"editorGroupHeader.tabsBackground": "#2e3440",
@@ -116,6 +114,7 @@
116114
"list.activeSelectionForeground": "#2e3440",
117115
"list.inactiveSelectionBackground": "#434c5e",
118116
"list.inactiveSelectionForeground": "#d8dee9",
117+
"list.inactiveFocusBackground": "#434c5ecc",
119118
"list.hoverForeground": "#eceff4",
120119
"list.focusForeground": "#d8dee9",
121120
"list.focusBackground": "#88c0d099",
@@ -160,7 +159,7 @@
160159
"peekView.border": "#4c566a",
161160
"peekViewEditor.background": "#2e3440",
162161
"peekViewEditorGutter.background": "#2e3440",
163-
"peekViewEditor.matchHighlightBackground": "#88c0d0cc",
162+
"peekViewEditor.matchHighlightBackground": "#88c0d04d",
164163
"peekViewResult.background": "#2e3440",
165164
"peekViewResult.fileForeground": "#88c0d0",
166165
"peekViewResult.lineForeground": "#d8dee966",
@@ -261,7 +260,7 @@
261260
"name": "Comment",
262261
"scope": "comment",
263262
"settings": {
264-
"foreground": "#4C566A"
263+
"foreground": "#616E88"
265264
}
266265
},
267266
{
@@ -440,7 +439,7 @@
440439
"punctuation.start.definition.comment"
441440
],
442441
"settings": {
443-
"foreground": "#4C566A"
442+
"foreground": "#616E88"
444443
}
445444
},
446445
{
@@ -767,7 +766,7 @@
767766
"source.java punctuation.definition.tag.end.javadoc"
768767
],
769768
"settings": {
770-
"foreground": "#4C566A"
769+
"foreground": "#616E88"
771770
}
772771
},
773772
{
@@ -839,9 +838,20 @@
839838
},
840839
{
841840
"name": "[JavaScript] String Template Literals Punctuation",
842-
"scope": "source.js string.template punctuation.definition.template-expression",
841+
"scope": [
842+
"source.js string.quoted.template punctuation.quasi.element.begin",
843+
"source.js string.quoted.template punctuation.quasi.element.end",
844+
"source.js string.template punctuation.definition.template-expression"
845+
],
843846
"settings": {
844-
"foreground": "#5E81AC"
847+
"foreground": "#81A1C1"
848+
}
849+
},
850+
{
851+
"name": "[JavaScript] Interpolated String Template Punctuation Functions",
852+
"scope": "source.js string.quoted.template meta.method-call.with-arguments",
853+
"settings": {
854+
"foreground": "#ECEFF4"
845855
}
846856
},
847857
{
@@ -863,9 +873,9 @@
863873
},
864874
{
865875
"name": "[JavaScript] Variable Other Object",
866-
"scope": "source.js meta.var.expr variable.other.object",
876+
"scope": "source.js variable.other.object",
867877
"settings": {
868-
"foreground": "#8FBCBB"
878+
"foreground": "#D8DEE9"
869879
}
870880
},
871881
{
@@ -977,7 +987,7 @@
977987
"name": "[Markdown] Markup Quote Punctuation Definition",
978988
"scope": "text.html.markdown markup.quote",
979989
"settings": {
980-
"foreground": "#4C566A"
990+
"foreground": "#616E88"
981991
}
982992
},
983993
{
@@ -1008,6 +1018,13 @@
10081018
"foreground": "#88C0D0"
10091019
}
10101020
},
1021+
{
1022+
"name": "[Perl] Perl Sigils",
1023+
"scope": "source.perl punctuation.definition.variable",
1024+
"settings": {
1025+
"foreground": "#D8DEE9"
1026+
}
1027+
},
10111028
{
10121029
"name": "[PHP] Meta Function-Call Object",
10131030
"scope": ["source.php meta.function-call", "source.php meta.function-call.object"],
@@ -1024,7 +1041,7 @@
10241041
},
10251042
{
10261043
"name": "[Python] Function Call",
1027-
"scope": ["source.python meta.function-call", "source.python meta.function-call.generic"],
1044+
"scope": "source.python meta.function-call.generic",
10281045
"settings": {
10291046
"foreground": "#88C0D0"
10301047
}

0 commit comments

Comments
 (0)