Skip to content

Improved syntax highlighting support for Rust#240

Merged
arcticicestudio merged 1 commit into
nordtheme:developfrom
vhladko:feature/gh-167-better-rust-support
Jan 24, 2022
Merged

Improved syntax highlighting support for Rust#240
arcticicestudio merged 1 commit into
nordtheme:developfrom
vhladko:feature/gh-167-better-rust-support

Conversation

@vhladko
Copy link
Copy Markdown
Contributor

@vhladko vhladko commented Dec 23, 2021

Resolves #167

Improved syntax highlighting support for Rust.

  1. Entity types are colorised with #8FBCBB;
  2. Macros are colorised with #88C0D0 and bold font to make them visually different from "normal" functions.
  3. Attributes and derives are colored with #5E81AC.
  4. Interpolation brackets are colored with #A3BE8C to meet whole string color. ( Not sure about this one, in TS they are different, but in a Vim theme, they are equal for Rust language )
  5. As a result of 1, import statements and paths are better colored with keyword and type colors.

Before

Screenshot 2021-12-23 at 15 46 51

After

Screenshot 2021-12-23 at 15 46 17

@arcticicestudio
Copy link
Copy Markdown
Contributor

Hi @vhladko 👋, thanks for your contribution 👍
I'll try to review and test the changes within the next weeks.

@vhladko
Copy link
Copy Markdown
Contributor Author

vhladko commented Dec 29, 2021

Hey there @arcticicestudio, cool, waiting for your feedback ! :)

@vhladko
Copy link
Copy Markdown
Contributor Author

vhladko commented Jan 11, 2022

Hello, @arcticicestudio , any updates on this one ?

@arcticicestudio arcticicestudio added this to the Next milestone Jan 13, 2022
Copy link
Copy Markdown
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vhladko There are over 400+ other issues & PRs so time is way too limited to get everything done quickly 🙈
Anyway, since #167 is a real long-time issue this should be finally resolved. I've reviewed the changes and added suggestions as well as an addition.

Comment thread themes/nord-color-theme.json Outdated
Comment thread themes/nord-color-theme.json Outdated
Comment thread themes/nord-color-theme.json
Comment thread themes/nord-color-theme.json Outdated
Comment thread themes/nord-color-theme.json Outdated
Comment thread themes/nord-color-theme.json
@vhladko vhladko force-pushed the feature/gh-167-better-rust-support branch from 43ca4fd to 362fca9 Compare January 14, 2022 15:47
@vhladko
Copy link
Copy Markdown
Contributor Author

vhladko commented Jan 14, 2022

@arcticicestudio sure, I did't want to push you. I've applied all your suggestions.

Copy link
Copy Markdown
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks again 🚀

@arcticicestudio
Copy link
Copy Markdown
Contributor

arcticicestudio commented Jan 24, 2022

Release note & changelog assets

Before

After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better support for Rust syntax highlight

3 participants