Drop unsupported pytest-dotenv package#44
Open
RedLeader962 wants to merge 1 commit intodevfrom
Open
Conversation
- Added guards to handle missing DNA template sources gracefully, ensuring that patches skip such scenarios with warnings instead of failing. - Refactored logic in patch handling to support multi-line and delimiter- containing patterns using a Python-based replacement approach. - Removed unsupported `pytest-dotenv` package, which conflicts with `pytest-env`, improving dependency compatibility. - Enhanced backward compatibility for bash 3.2 in macOS by replacing associative arrays in patches with indexed arrays. - Updated regression tests to validate fixes for bugs in previous patch versions. - Minor cleanup and developer tools improvements to streamline patch application. Issue NMO-834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Package
pytest-dotenvis not maintained andpytest-envversion 1.6.0 (which is maintained) introduce a flag that conflict withpytest-dotenvIssue NMO-834
Checklist:
Code related
commit_msg_reference.mdin the repository root for detailsPR creation related
base refbranch is set to thedevbranch (the build-system won't be triggered otherwise)devbranch (the build-system will reject it otherwise)PR description related
# <issue-id>if changes are of typefixNote for repository admins
Release PR related
push/mergeon the default branch (ie:main) and thereleasebranch.draftmode until all the release reviewers are ready to push the release.release->mainbranch is created (not in draft mode), it triggers the build-system testmainbranch, it triggers the semantic-release automation