fix(snacks): set preview buffer modifiable before writing#72
Open
xavier7179 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses an error in the Snacks.nvim picker preview rendering by ensuring the preview buffer is set to modifiable before calling nvim_buf_set_lines, allowing preview content to be written successfully.
Changes:
- Set
vim.bo[ctx.buf].modifiable = truebefore writing preview content in the Snacks “connect” picker. - Set
vim.bo[ctx.buf].modifiable = truebefore writing preview content in the Snacks “edit ssh config” picker.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
94
to
97
| local lines = build_host_preview(hosts, ctx.item.name) | ||
| vim.bo[ctx.buf].modifiable = true -- avoid Snacks.nvim tossing an error due to the buffer being readonly | ||
| vim.api.nvim_buf_set_lines(ctx.buf, 0, -1, false, lines) | ||
| vim.bo[ctx.buf].filetype = "sshconfig" |
Comment on lines
+142
to
144
| vim.bo[ctx.buf].modifiable = true -- avoid Snacks.nvim tossing an error due to the buffer being readonly | ||
| vim.api.nvim_buf_set_lines(ctx.buf, 0, -1, false, lines) | ||
| vim.bo[ctx.buf].filetype = "sshconfig" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snacks.nvim picker through an error due to the preview buffer not being modifiable. This is a workaround to make the buffer modifiable, allowing the picker to function correctly.