Skip to content

Commit a19dfc4

Browse files
committed
Fix compilation error with load_material
1 parent 60e75d2 commit a19dfc4

5 files changed

Lines changed: 8 additions & 30 deletions

File tree

examples/custom_material.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ async fn main() {
5353
fragment: FRAGMENT,
5454
},
5555
MaterialParams {
56-
uniforms: vec![("test_color".to_string(), UniformType::Float4)],
56+
uniforms: vec![UniformDesc::new("test_color", UniformType::Float4)],
5757
pipeline_params,
5858
..Default::default()
5959
},
@@ -65,7 +65,7 @@ async fn main() {
6565
vertex: VERTEX,
6666
fragment: FRAGMENT_WITH_ARRAY,
6767
},
68-
MaterialParams2 {
68+
MaterialParams {
6969
uniforms: vec![UniformDesc::array(
7070
UniformDesc::new("test_color", UniformType::Float4),
7171
10,

examples/screen_texture.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ async fn main() {
1010
fragment: LENS_FRAGMENT_SHADER,
1111
},
1212
MaterialParams {
13-
uniforms: vec![("Center".to_owned(), UniformType::Float2)],
13+
uniforms: vec![UniformDesc::new("Center", UniformType::Float2)],
1414
..Default::default()
1515
},
1616
)

examples/shadertoy.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ async fn main() {
337337
if need_update {
338338
let uniforms = uniforms
339339
.iter()
340-
.map(|(name, uniform)| (name.clone(), uniform.uniform_type()))
340+
.map(|(name, uniform)| UniformDesc::new(name, uniform.uniform_type()))
341341
.collect::<Vec<_>>();
342342

343343
match load_material(

src/material.rs

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//! Custom materials - shaders, uniforms.
22
33
use crate::{get_context, quad_gl::GlPipeline, texture::Texture2D, tobytes::ToBytes, Error};
4-
use miniquad::{PipelineParams, UniformDesc, UniformType};
4+
use miniquad::{PipelineParams, UniformDesc};
55
use std::sync::Arc;
66

77
#[derive(PartialEq)]
@@ -54,39 +54,17 @@ pub struct MaterialParams {
5454
pub pipeline_params: PipelineParams,
5555

5656
/// List of custom uniforms used in this material
57-
pub uniforms: Vec<(String, UniformType)>,
57+
pub uniforms: Vec<UniformDesc>,
5858

5959
/// List of textures used in this material
6060
pub textures: Vec<String>,
6161
}
6262

63-
impl Into<MaterialParams2> for MaterialParams {
64-
fn into(self) -> MaterialParams2 {
65-
MaterialParams2 {
66-
pipeline_params: self.pipeline_params,
67-
uniforms: self
68-
.uniforms
69-
.into_iter()
70-
.map(|u| UniformDesc::new(&u.0, u.1))
71-
.collect(),
72-
textures: self.textures,
73-
}
74-
}
75-
}
76-
77-
#[derive(Default)]
78-
pub struct MaterialParams2 {
79-
pub pipeline_params: PipelineParams,
80-
pub uniforms: Vec<miniquad::UniformDesc>,
81-
pub textures: Vec<String>,
82-
}
83-
8463
pub fn load_material(
8564
shader: crate::ShaderSource,
86-
params: impl Into<MaterialParams2>,
65+
params: MaterialParams,
8766
) -> Result<Material, Error> {
8867
let context = &mut get_context();
89-
let params = params.into();
9068

9169
let pipeline = context.gl.make_pipeline(
9270
&mut *context.quad_context,

src/prelude.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pub use crate::color::{colors::*, Color};
1616
pub use crate::quad_gl::{DrawMode, GlPipeline, QuadGl, Vertex};
1717
pub use glam;
1818
pub use miniquad::{
19-
conf::Conf, Comparison, PipelineParams, ShaderError, ShaderSource, UniformType,
19+
conf::Conf, Comparison, PipelineParams, ShaderError, ShaderSource, UniformDesc, UniformType,
2020
};
2121
pub use quad_rand as rand;
2222

0 commit comments

Comments
 (0)