Skip to content

ci: add signed commit check#1244

Merged
JeyJeyGao merged 2 commits into
notaryproject:mainfrom
7h3-3mp7y-m4n:signcommit
Apr 25, 2025
Merged

ci: add signed commit check#1244
JeyJeyGao merged 2 commits into
notaryproject:mainfrom
7h3-3mp7y-m4n:signcommit

Conversation

@7h3-3mp7y-m4n
Copy link
Copy Markdown
Contributor

@7h3-3mp7y-m4n 7h3-3mp7y-m4n commented Mar 30, 2025

Add new signed commits in PR on .github/workflow/build.yml #1136 with comments.

@7h3-3mp7y-m4n
ci: add signed commit check
0def038 
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@7h3-3mp7y-m4n 7h3-3mp7y-m4n requested a review from a user March 30, 2025 09:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (b1e4687) to head (5852482).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1244   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files          68       68           
  Lines        3847     3847           
=======================================
  Hits         2961     2961           
  Misses        682      682           
  Partials      204      204

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FeynmanZhou
FeynmanZhou reviewed Mar 31, 2025
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
@7h3-3mp7y-m4n
add project brand
5852482 
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
FeynmanZhou
FeynmanZhou approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Apr 10, 2025

@JeyJeyGao @patrickzheng200 Would you mind reviewing this PR? If it looks good, we can merge it.

@ghost
Copy link
Copy Markdown

ghost commented Apr 11, 2025

@JeyJeyGao @patrickzheng200 Would you mind reviewing this PR? If it looks good, we can merge it.

@FeynmanZhou A kindly reminder, you used the old account to @ me.

@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Apr 11, 2025

@FeynmanZhou A kindly reminder, you used the old account to @ me.

@Two-Hearts Ah, my bad. I miss that Patrick :-D Should we remove old account patrickzheng200 from Notary Project GitHub org so that people will not accidentally tag the wrong ID?

@FeynmanZhou
Copy link
Copy Markdown
Member

FeynmanZhou commented Apr 18, 2025

@Two-Hearts @JeyJeyGao Does this PR look good to you?

ghost
ghost approved these changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 759cd8c into notaryproject:main Apr 25, 2025
7 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
@7h3-3mp7y-m4n @FeynmanZhou
ci: add signed commit check (notaryproject#1244)
a1fe421 
Add new signed commits in PR on `.github/workflow/build.yml` notaryproject#1136 with
comments.

---------

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

+2 more reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7h3-3mp7y-m4n @FeynmanZhou @JeyJeyGao