Skip to content

fix: fix linter complain, don't use deprecated types#1273

Merged
1 commit merged into
notaryproject:mainfrom
qba73:fix/staticcheck-rev2
May 12, 2025
Merged

fix: fix linter complain, don't use deprecated types#1273
1 commit merged into
notaryproject:mainfrom
qba73:fix/staticcheck-rev2

Conversation

@qba73

@qba73 qba73 commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

This PR fixes issue highlighted by staticcheck - using deprecated constructs.

It partially addresses #1256

Signed-off-by: Jakub Jarosz <jakub@jarosz.dev>
@codecov

codecov Bot commented Apr 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (4acbc76) to head (420c7c9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   76.96%   76.96%           
=======================================
  Files          68       68           
  Lines        3847     3847           
=======================================
  Hits         2961     2961           
  Misses        682      682           
  Partials      204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeyJeyGao JeyJeyGao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost changed the title fix linter complain, don't use deprecated types fix: fix linter complain, don't use deprecated types May 12, 2025

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit c68425f into notaryproject:main May 12, 2025
@qba73 qba73 deleted the fix/staticcheck-rev2 branch May 12, 2025 04:41
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
)

Signed-off-by: Jakub Jarosz <jakub@jarosz.dev>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants