Add targeted noqa comments for PLC0415 and S603 lint errors

Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>

Author: Copilot

handlers/task_getter.py

@@ -22,10 +22,10 @@ def factory(
     ) -> TaskGetterFromGitHub | TaskGetterFromGitLab:
         # Import here to avoid circular import issues - this is a legitimate use case
         if task_source == "github":
-            from .task_getter_github import TaskGetterFromGitHub
+            from .task_getter_github import TaskGetterFromGitHub  # noqa: PLC0415
             return TaskGetterFromGitHub(config, mcp_clients)
         if task_source == "gitlab":
-            from .task_getter_gitlab import TaskGetterFromGitLab
+            from .task_getter_gitlab import TaskGetterFromGitLab  # noqa: PLC0415
             return TaskGetterFromGitLab(config, mcp_clients)
         msg = f"Unknown task_source: {task_source}"
         raise ValueError(msg)

tests/integration/test_simple_workflow.py

@@ -15,10 +15,10 @@
 
 def _import_test_modules() -> tuple[type, type, type, type]:
     """Import test modules after mocking is set up."""
-    from handlers.task_getter_github import TaskGitHubIssue
-    from handlers.task_handler import TaskHandler
-    from tests.mocks.mock_llm_client import MockLLMClient
-    from tests.mocks.mock_mcp_client import MockMCPToolClient
+    from handlers.task_getter_github import TaskGitHubIssue  # noqa: PLC0415
+    from handlers.task_handler import TaskHandler  # noqa: PLC0415
+    from tests.mocks.mock_llm_client import MockLLMClient  # noqa: PLC0415
+    from tests.mocks.mock_mcp_client import MockMCPToolClient  # noqa: PLC0415
     return TaskGitHubIssue, TaskHandler, MockLLMClient, MockMCPToolClient
 
 

tests/integration/test_workflow.py

@@ -21,13 +21,16 @@
 
 def _import_test_modules() -> tuple[type, ...]:
     """Import test modules after mocking is set up."""
-    from handlers.task_factory import GitHubTaskFactory, GitLabTaskFactory
-    from handlers.task_getter_github import TaskGetterFromGitHub, TaskGitHubIssue
-    from handlers.task_getter_gitlab import TaskGetterFromGitLab, TaskGitLabIssue
-    from handlers.task_handler import TaskHandler
-    from handlers.task_key import GitHubIssueTaskKey, GitLabIssueTaskKey
-    from tests.mocks.mock_llm_client import MockLLMClient, MockLLMClientWithToolCalls
-    from tests.mocks.mock_mcp_client import MockMCPToolClient
+    from handlers.task_factory import GitHubTaskFactory, GitLabTaskFactory  # noqa: PLC0415
+    from handlers.task_getter_github import TaskGetterFromGitHub, TaskGitHubIssue  # noqa: PLC0415
+    from handlers.task_getter_gitlab import TaskGetterFromGitLab, TaskGitLabIssue  # noqa: PLC0415
+    from handlers.task_handler import TaskHandler  # noqa: PLC0415
+    from handlers.task_key import GitHubIssueTaskKey, GitLabIssueTaskKey  # noqa: PLC0415
+    from tests.mocks.mock_llm_client import (  # noqa: PLC0415
+        MockLLMClient,
+        MockLLMClientWithToolCalls,
+    )
+    from tests.mocks.mock_mcp_client import MockMCPToolClient  # noqa: PLC0415
 
     return (
         GitHubTaskFactory, GitLabTaskFactory, TaskGetterFromGitHub, TaskGitHubIssue,

tests/real_integration/base_framework.py

@@ -226,7 +226,7 @@ def run_coding_agent(self, timeout: int = 300) -> subprocess.CompletedProcess:
         # コーディングエージェントを実行
         agent_path = Path(__file__).parent.parent.parent / "main.py"
 
-        result = subprocess.run(
+        result = subprocess.run(  # noqa: S603
             [sys.executable, str(agent_path)],
             check=False,
             env=env,
@@ -291,7 +291,7 @@ def verify_python_execution(self, file_path: str, expected_output: str) -> bool:
             tmp_path = tmp.name
 
         try:
-            result = subprocess.run(
+            result = subprocess.run(  # noqa: S603
                 [sys.executable, tmp_path],
                 check=False,
                 capture_output=True,

tests/real_integration/check_config.py

@@ -129,7 +129,7 @@ def check_mcp_servers() -> bool:
 
         # This subprocess call is safe: using validated npm command with fixed arguments
         npm_args = [npm_cmd, "list", "@zereight/mcp-gitlab"]
-        result = subprocess.run(
+        result = subprocess.run(  # noqa: S603
             npm_args,
             check=False,
             capture_output=True,

tests/real_integration/demo.py

@@ -42,7 +42,7 @@ def run_config_check() -> bool:
     try:
         # Safe subprocess call: using sys.executable and hardcoded script path
         demo_args = [sys.executable, "tests/real_integration/check_config.py"]
-        result = subprocess.run(
+        result = subprocess.run(  # noqa: S603
             demo_args,
             check=False,
             capture_output=True,
@@ -67,7 +67,7 @@ def run_mock_tests() -> bool:
     try:
         # Safe subprocess call: using sys.executable and hardcoded script path
         test_args = [sys.executable, "tests/run_tests.py", "--mock"]
-        result = subprocess.run(
+        result = subprocess.run(  # noqa: S603
             test_args,
             check=False,
             capture_output=True,
@@ -95,7 +95,7 @@ def run_real_tests() -> bool:
     try:
         # Safe subprocess call: using sys.executable and hardcoded script path
         real_test_args = [sys.executable, "tests/run_tests.py", "--real"]
-        result = subprocess.run(
+        result = subprocess.run(  # noqa: S603
             real_test_args,
             check=False,
             text=True,

tests/unit/test_task_handler.py

@@ -19,18 +19,18 @@
 
 def _import_test_modules() -> tuple[type, ...]:
     """Import test modules after mocking is set up."""
-    import pytest
-    from mcp import McpError
+    import pytest  # noqa: PLC0415
+    from mcp import McpError  # noqa: PLC0415
 
-    from handlers.task_getter_github import TaskGitHubIssue
-    from handlers.task_getter_gitlab import TaskGitLabIssue
-    from handlers.task_handler import TaskHandler
-    from tests.mocks.mock_llm_client import (
+    from handlers.task_getter_github import TaskGitHubIssue  # noqa: PLC0415
+    from handlers.task_getter_gitlab import TaskGitLabIssue  # noqa: PLC0415
+    from handlers.task_handler import TaskHandler  # noqa: PLC0415
+    from tests.mocks.mock_llm_client import (  # noqa: PLC0415
         MockLLMClient,
         MockLLMClientWithErrors,
         MockLLMClientWithToolCalls,
     )
-    from tests.mocks.mock_mcp_client import MockMCPToolClient
+    from tests.mocks.mock_mcp_client import MockMCPToolClient  # noqa: PLC0415
 
     return (pytest, McpError, TaskGitHubIssue, TaskGitLabIssue, TaskHandler,
             MockLLMClient, MockLLMClientWithErrors, MockLLMClientWithToolCalls,