Remove GitHub and GitLab mocking per user request

Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>

Author: Copilot

tests/README.md

@@ -1,15 +1,15 @@
 # Test Automation for Coding Agent
 
-This directory contains comprehensive test automation for the coding agent project, implementing the requirements from issue #17.
+This directory contains test automation for the coding agent project, modified per user request to remove GitHub and GitLab mocking.
 
 ## Overview
 
 The test automation framework provides:
 
-1. **Mock MCP Servers** - Simulates GitHub and GitLab MCP server interactions
-2. **Mock LLM Client** - Provides configurable LLM responses for testing
-3. **Unit Tests** - Tests individual components (TaskGetter, TaskHandler, etc.)
-4. **Integration Tests** - Tests complete workflows end-to-end
+1. **Mock LLM Client** - Provides configurable LLM responses for testing
+2. **Basic MCP Client Mock** - Generic MCP client interface without service-specific data
+3. **Unit Tests** - Tests basic functionality without external service dependencies
+4. **Integration Tests** - Tests framework components working together
 5. **Test Configuration** - Mock-enabled configuration for testing
 
 ## Test Structure
@@ -19,44 +19,36 @@ tests/
 ├── __init__.py
 ├── test_config.yaml          # Test configuration with mock providers
 ├── run_tests.py              # Test runner script
+├── demo.py                   # Demo of testing framework
 ├── mocks/                    # Mock implementations
 │   ├── __init__.py
-│   ├── mock_mcp_client.py    # Mock MCP server for GitHub/GitLab
+│   ├── mock_mcp_client.py    # Generic MCP client mock (GitHub/GitLab specifics removed)
 │   └── mock_llm_client.py    # Mock LLM client with configurable responses
 ├── unit/                     # Unit tests
-│   ├── test_github_tasks.py  # GitHub task management tests
-│   ├── test_gitlab_tasks.py  # GitLab task management tests
-│   └── test_task_handler.py  # Task processing and LLM interaction tests
+│   ├── test_github_tasks.py  # Basic GitHub-related functionality tests (no API mocking)
+│   └── test_gitlab_tasks.py  # Basic GitLab-related functionality tests (no API mocking)
 └── integration/              # Integration tests
-    └── test_workflow.py      # End-to-end workflow tests
+    └── test_workflow.py      # Basic framework integration tests
 ```
 
 ## Key Features Tested
 
-### GitHub Integration
-- Issue discovery and filtering by labels
-- Task state management (coding agent → processing → done)
-- Issue commenting and updates
-- Pull request handling
-
-### GitLab Integration  
-- Issue discovery and filtering by labels
-- Task state management via labels
-- Issue discussions and updates
-- Merge request handling
-
-### Task Processing
-- LLM interaction with tool calls
+### LLM Integration
+- Mock LLM client with configurable responses
 - JSON response parsing and error handling
-- Task queue operations
-- Workflow state transitions
-
-### Error Handling
-- Invalid JSON response handling
-- Tool call failures
-- Network/API error simulation
-- Recovery mechanisms
-
+- Multi-turn conversation simulation
+- Error recovery testing
+
+### Basic GitHub/GitLab Functionality (No Service Mocking)
+- URL parsing and basic data structure handling
+- Label manipulation
+- Prompt formatting
+- Basic validation without API calls
+
+### Framework Integration
+- Mock components working together
+- Configuration loading
+- Basic workflow validation
 ## Running Tests
 
 ### Run All Tests
@@ -78,17 +70,21 @@ python3 -m tests.run_tests --integration
 ```bash
 python3 -m unittest tests.unit.test_github_tasks
 python3 -m unittest tests.unit.test_gitlab_tasks
-python3 -m unittest tests.unit.test_task_handler
 python3 -m unittest tests.integration.test_workflow
 ```
 
+### Run Interactive Demo
+```bash
+python3 tests/demo.py
+```
+
 ## Mock Components
 
 ### Mock MCP Client (`MockMCPToolClient`)
-- Simulates GitHub and GitLab MCP server responses
-- Provides realistic mock data for issues, comments, labels
-- Supports all required MCP tools (search_issues, get_issue, update_issue, etc.)
-- Handles both GitHub and GitLab API patterns
+- Generic MCP client interface for testing
+- No longer provides GitHub/GitLab specific data (removed per user request)
+- Returns empty responses for tool calls
+- Supports basic MCP lifecycle operations
 
 ### Mock LLM Client (`MockLLMClient`)
 - Configurable response queue for testing different scenarios
@@ -103,35 +99,29 @@ The test configuration (`test_config.yaml`) uses mock providers:
 ```yaml
 llm:
   provider: "mock"  # Uses MockLLMClient instead of real LLM
-  
-mcp_servers:
-  - mcp_server_name: "github"
-    command: ["mock_github_server"]  # Mock GitHub MCP server
-  - mcp_server_name: "gitlab" 
-    command: ["mock_gitlab_server"]  # Mock GitLab MCP server
 ```
 
 ## Test Coverage
 
-The tests cover the main requirements from the original issue:
+The tests cover basic framework functionality without external service dependencies:
 
-1. ✅ **GitHub/GitLab Integration**: Tests issue/PR/MR retrieval and state management
-2. ✅ **Mock LLM Usage**: Verifies MCP server interaction with mock LLMs  
-3. ✅ **State Management**: Tests label transitions (coding agent → processing → done)
-4. ✅ **Error Handling**: Tests recovery from JSON parsing and tool call errors
-5. ✅ **Workflow Automation**: End-to-end tests of the complete coding agent workflow
+1. ✅ **LLM Mocking**: Mock LLM client with configurable responses
+2. ✅ **Basic MCP Interface**: Generic MCP client operations
+3. ✅ **Framework Integration**: Components working together
+4. ✅ **Error Handling**: JSON parsing and error recovery
+5. ✅ **Configuration**: Test configuration loading and validation
 
 ## Benefits
 
-- **No External Dependencies**: Tests run without requiring actual GitHub/GitLab tokens or LLM API access
+- **No External Dependencies**: Tests run without requiring GitHub/GitLab tokens or LLM API access
 - **Fast Execution**: Mock components enable rapid test execution
 - **Reliable**: Tests are deterministic and don't depend on external service availability
-- **Comprehensive**: Covers both happy path and error scenarios
+- **Simplified**: Focused on core framework functionality without service-specific complexity
 - **Maintainable**: Well-structured with clear separation of concerns
 
-## Future Enhancements
+## Important Notes
 
-- Add performance testing for high-volume task processing
-- Implement more sophisticated error scenarios
-- Add tests for additional MCP server integrations
-- Include load testing for concurrent task processing
+- **GitHub and GitLab mocking has been removed** per user request
+- Tests now focus on basic functionality and LLM interaction patterns
+- No actual GitHub/GitLab API calls are mocked or simulated
+- Framework tests validate component integration without service dependencies

tests/demo.py

@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 """
 Example usage of the coding agent test automation framework
+(GitHub/GitLab mocking removed per user request)
 """
 import os
 import sys
@@ -14,31 +15,24 @@
 
 
 def demonstrate_mock_mcp_client():
-    """Demonstrate mock MCP client usage"""
+    """Demonstrate mock MCP client usage (GitHub/GitLab specifics removed)"""
     print("=== Mock MCP Client Demo ===")
 
-    # Create GitHub mock client
-    github_config = {'mcp_server_name': 'github', 'command': ['mock']}
-    github_client = MockMCPToolClient(github_config)
+    # Create generic mock client
+    test_config = {'mcp_server_name': 'test_server', 'command': ['mock']}
+    test_client = MockMCPToolClient(test_config)
 
-    # Show available tools
-    tools = github_client.list_tools()
-    print(f"GitHub tools: {[tool['name'] for tool in tools]}")
+    # Show available tools (should return empty list now)
+    tools = test_client.list_tools()
+    print(f"Test server tools: {[tool.get('name', 'unnamed') for tool in tools]}")
 
-    # Search for issues
-    issues = github_client.call_tool('search_issues', {'q': 'label:"coding agent"'})
-    print(f"Found {len(issues['items'])} mock issues")
+    # Test basic tool call (will return empty dict)
+    result = test_client.call_tool('test_tool', {'param': 'value'})
+    print(f"Tool call result: {result}")
 
-    # Get issue details
-    issue = github_client.call_tool('get_issue', {'issue_number': 1})
-    print(f"Issue: {issue['title']}")
-    
-    # Add comment
-    comment = github_client.call_tool('add_issue_comment', {
-        'issue_number': 1, 
-        'body': 'This is a test comment'
-    })
-    print(f"Added comment: {comment['body']}")
+    # Test system prompt
+    prompt = test_client.system_prompt
+    print(f"System prompt: {prompt}")
     print()
 
 
@@ -53,7 +47,7 @@ def demonstrate_mock_llm_client():
     llm_client.send_system_prompt("You are a helpful coding assistant.")
 
     # Send user message
-    llm_client.send_user_message("Please help me with issue #1")
+    llm_client.send_user_message("Please help me with a test task")
 
     # Get responses
     response1, _ = llm_client.get_response()
@@ -69,7 +63,7 @@ def demonstrate_mock_llm_client():
 
 
 def demonstrate_test_workflow():
-    """Demonstrate the complete test workflow"""
+    """Demonstrate the basic test workflow without GitHub/GitLab specifics"""
     print("=== Test Workflow Demo ===")
 
     # Load test config
@@ -79,18 +73,15 @@ def demonstrate_test_workflow():
 
     print("Test configuration loaded:")
     print(f"  LLM Provider: {config['llm']['provider']}")
-    print(f"  GitHub Bot Label: {config['github']['bot_label']}")
-    print(f"  GitLab Bot Label: {config['gitlab']['bot_label']}")
+    # Note: GitHub/GitLab specific config removed per user request
     print()
 
-    # Create mock clients
-    github_client = MockMCPToolClient({'mcp_server_name': 'github', 'command': ['mock']})
-    gitlab_client = MockMCPToolClient({'mcp_server_name': 'gitlab', 'command': ['mock']})
+    # Create mock clients (generic, not service-specific)
+    test_client = MockMCPToolClient({'mcp_server_name': 'test_server', 'command': ['mock']})
     llm_client = MockLLMClient(config)
 
     print("Mock clients created successfully!")
-    print(f"  GitHub client has {len(github_client.mock_data['issues'])} mock issues")
-    print(f"  GitLab client has {len(gitlab_client.mock_data['issues'])} mock issues")
+    print(f"  Test MCP client initialized with server: {test_client.server_name}")
     print(f"  LLM client has {len(llm_client.response_queue)} default responses")
     print()
 
@@ -118,6 +109,7 @@ def run_sample_tests():
 def main():
     """Main demo function"""
     print("Coding Agent Test Automation Framework Demo")
+    print("(GitHub/GitLab mocking removed per user request)")
     print("=" * 50)
     print()
 
@@ -133,6 +125,9 @@ def main():
         print("  python3 -m tests.run_tests")
         print("  python3 -m tests.run_tests --unit")
         print("  python3 -m tests.run_tests --integration")
+        print()
+        print("Note: GitHub and GitLab mocking has been removed per user request.")
+        print("Tests now focus on LLM client mocking and general framework functionality.")
 
     except Exception as e:
         print(f"❌ Demo failed: {e}")