feature/series#125
Open
marcjulian wants to merge 23 commits into
Open
Conversation
Member
marcjulian
commented
Dec 1, 2020
marcjulian
commented
- feat(series): add series page
- feat(series): map chapter items and sort by weight
- feat(tailwind): optin to future changes
* display chapter items and link to post * display 3 tag icons
|
Visit the preview URL for this PR (updated for commit c45da56): https://notiz-dev--pr125-feature-series-1ezoqkdc.web.app (expires Mon, 08 Feb 2021 16:18:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
# Conflicts: # tailwind.config.js
* move chapters into prose content
Open
Member
Author
|
* scully-content needs its own div otherwise *ngIf="page$ | async as page" is not correctly interpreted
* ScullyRoutesService.getCurrent() subscribes to route-events
* show search type in badge
garygrossgarten
approved these changes
Jan 6, 2021
Member
garygrossgarten
left a comment
garygrossgarten
left a comment
There was a problem hiding this comment.
Refactor out chip class, otherwise LGTM
Member
Author
|
@garygrossgarten Never mind, I deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.