Skip to content

Re-introduce sprite rendering to the ECS.#634

Merged
FiniteReality merged 17 commits into
mainfrom
feature/sprite-rendering-system
May 25, 2026
Merged

Re-introduce sprite rendering to the ECS.#634
FiniteReality merged 17 commits into
mainfrom
feature/sprite-rendering-system

Conversation

@RubyNova
Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This will bring us back up to feature parity with where we were before the graphics LLAPI refactor. Sprites should render and they will also respect the entity graph.

Is there an open issue that this resolves? If so, please link it here.
No.

What is the current behavior? (You can also link to an open issue here)
the ECS cannot render anything at all. :)

What is the new behavior (if this is a feature change)?
The ECS can render things. :)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not anything that is more broken than is currently in main :^)

Other information:
This is a lot of code. Sorry lol.

@RubyNova RubyNova changed the title This is truly the ECS rendering code of all time. Re-introduce sprite rendering to the ECS. May 17, 2026
@RubyNova RubyNova marked this pull request as ready for review May 21, 2026 23:13
@RubyNova RubyNova requested a review from FiniteReality as a code owner May 21, 2026 23:13
Comment thread Ecs/Core/include/NovelRT/Ecs/MiscTemplateImpls.hpp
Comment thread Ecs/Graphics/include/NovelRT/Ecs/Graphics/Components/Camera.hpp
Comment thread Ecs/Graphics/include/NovelRT/Ecs/Graphics/Components/Sprite.hpp
Comment thread Ecs/Graphics/include/NovelRT/Ecs/Graphics/Components/Viewport.hpp
Comment thread ResourceManagement/Desktop/DesktopResourceLoader.cpp
Comment thread Windowing/Glfw/Vulkan/GlfwWindowProviderVulkanGraphicsProvider.cpp
Comment thread Windowing/Glfw/GlfwWindowProvider.cpp Outdated
Comment thread Graphics/Vulkan/VulkanGraphicsSwapchain.cpp Outdated
Comment thread Resources/Shaders/SpriteVertex.hlsl
@FiniteReality FiniteReality merged commit bc3c449 into main May 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants