Lua Editor Part 2#57
Merged
Merged
Conversation
…functions Add assert to UploadBufferHandler to prevent usage during the Render functions
Descriptor binding affected in-flight frames
There was a problem hiding this comment.
Pull request overview
This PR updates the Vulkan renderer’s per-frame synchronization around descriptor updates and staging uploads by introducing deferred buffer-descriptor writes (applied after the relevant frame-slot fence wait) and adding an explicit “unlock uploads” hook to re-enable staging uploads for the next frame phase.
Changes:
- Defer buffer descriptor writes via
DescriptorHandlerVK::FlushPendingBufferWrites()and invoke it fromRendererVK::FlipFrame()after waiting the frame fence. - Add
Renderer::UnlockUploads()/UploadBufferHandlerVK::UnlockUploads()and introduce an upload lock + assert to prevent render-thread staging uploads after the per-frame submit point. - Adjust
BindDescriptorAPIs to bind buffer descriptors byBufferID(resolving theVkBufferlater at flush time).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Renderer/Renderer/Renderers/Vulkan/RendererVK.h | Adds UnlockUploads() override to the Vulkan renderer interface. |
| Source/Renderer/Renderer/Renderers/Vulkan/RendererVK.cpp | Updates buffer descriptor binding semantics and flushes deferred buffer writes during FlipFrame; forwards UnlockUploads(). |
| Source/Renderer/Renderer/Renderers/Vulkan/Backend/UploadBufferHandlerVK.h | Adds UnlockUploads() API for the upload handler. |
| Source/Renderer/Renderer/Renderers/Vulkan/Backend/UploadBufferHandlerVK.cpp | Introduces a per-frame upload lock + render-thread assert; implements UnlockUploads(). |
| Source/Renderer/Renderer/Renderers/Vulkan/Backend/DescriptorHandlerVK.h | Changes buffer BindDescriptor signature and adds FlushPendingBufferWrites() + internal helper. |
| Source/Renderer/Renderer/Renderers/Vulkan/Backend/DescriptorHandlerVK.cpp | Implements pending per-slot buffer writes and per-frame-slot flush of vkUpdateDescriptorSets. |
| Source/Renderer/Renderer/Renderer.h | Extends the renderer interface with UnlockUploads() and documents intended usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Hierarchy, Inspector and AssetBrowser to Luau editors with the CanvasRenderer, gets rid of their C++/ImGui counterparts. Also cleans up old C++/ImGui based MapSelector.