Remove overly defensive entt ctx.contains<T> checks that we would prefer to fail loudly

Author: Pursche

Source/Game-Lib/Game-Lib/ECS/Systems/Editor/EditorTools.cpp

@@ -118,9 +118,6 @@ namespace ECS::Systems::Editor
                     return false;
 
                 entt::registry::context& ctx = registries->gameRegistry->ctx();
-                if (!ctx.contains<Singletons::EditorSelection>())
-                    return false;
-
                 auto& selection = ctx.get<Singletons::EditorSelection>();
                 if (selection.selectedEntity == entt::null || !registries->gameRegistry->valid(selection.selectedEntity))
                     return false;
@@ -324,9 +321,6 @@ namespace ECS::Systems::Editor
     void EditorTools::SetSelectedEntity(entt::registry& registry, entt::entity entity)
     {
         entt::registry::context& ctx = registry.ctx();
-        if (!ctx.contains<Singletons::EditorSelection>())
-            return;
-
         auto& selection = ctx.get<Singletons::EditorSelection>();
         if (selection.selectedEntity == entity)
             return;
@@ -338,9 +332,6 @@ namespace ECS::Systems::Editor
     void EditorTools::Update(entt::registry& registry, f32 /*deltaTime*/)
     {
         entt::registry::context& ctx = registry.ctx();
-        if (!ctx.contains<Singletons::EditorSelection>())
-            return;
-
         auto& selection = ctx.get<Singletons::EditorSelection>();
 
         GameRenderer* gameRenderer = ServiceLocator::GetGameRenderer();

Source/Game-Lib/Game-Lib/Scripting/Handlers/AssetHandler.cpp

@@ -190,12 +190,9 @@ namespace Scripting::Asset
 
         EnttRegistries* registries = ServiceLocator::GetEnttRegistries();
         entt::registry::context& ctx = registries->gameRegistry->ctx();
-        if (ctx.contains<ECS::Singletons::EditorSelection>())
-        {
-            auto& selection = ctx.get<ECS::Singletons::EditorSelection>();
-            selection.dragSpawnRequested = true;
-            selection.dragSpawnModelPath = relativeRaw;
-        }
+        auto& selection = ctx.get<ECS::Singletons::EditorSelection>();
+        selection.dragSpawnRequested = true;
+        selection.dragSpawnModelPath = relativeRaw;
 
         return 0;
     }

Source/Game-Lib/Game-Lib/Scripting/Handlers/EditorToolHandler.cpp

@@ -48,8 +48,6 @@ namespace Scripting::Editor
         if (!registries || !registries->gameRegistry)
             return nullptr;
         auto& ctx = registries->gameRegistry->ctx();
-        if (!ctx.contains<ECS::Singletons::EditorSelection>())
-            return nullptr;
         return &ctx.get<ECS::Singletons::EditorSelection>();
     }