Release 1.2.5: fix ux:icons:lock for UX Icons 3.x

HecFranco · HecFranco · commit 5335c9e42bb3 · 2026-06-18T09:28:04.000+02:00
diff --git a/.symfony/recipes/nowo-tech/password-toggle-bundle/1.2.3/post-install.txt b/.symfony/recipes/nowo-tech/password-toggle-bundle/1.2.3/post-install.txt
@@ -6,8 +6,10 @@ Password Toggle Bundle has been installed.
 
 Next steps:
 
-  1. Lock icons for production / offline use:
-     php bin/console ux:icons:lock tabler:eye tabler:eye-off
+  1. Lock icons used in Twig templates for production / offline use:
+     php bin/console ux:icons:lock
+
+     (UX Icons 3.x scans templates; no icon names as arguments. Use --force to overwrite locals.)
 
   2. Add the form theme in config/packages/twig.yaml if not already present:
      form_themes:
@@ -16,6 +18,6 @@ Next steps:
 Without Symfony Flex, install dependencies manually:
 
   composer require symfony/ux-icons symfony/http-client
-  php bin/console ux:icons:lock tabler:eye tabler:eye-off
+  php bin/console ux:icons:lock
 
 The default widget uses ux_icon(); without these packages icons are omitted (toggle still works).
diff --git a/.symfony/recipes/nowo-tech/password-toggle-bundle/1.2.4/post-install.txt b/.symfony/recipes/nowo-tech/password-toggle-bundle/1.2.4/post-install.txt
@@ -6,8 +6,10 @@ Password Toggle Bundle has been installed.
 
 Next steps:
 
-  1. Lock icons for production / offline use:
-     php bin/console ux:icons:lock tabler:eye tabler:eye-off
+  1. Lock icons used in Twig templates for production / offline use:
+     php bin/console ux:icons:lock
+
+     (UX Icons 3.x scans templates; no icon names as arguments. Use --force to overwrite locals.)
 
   2. Add the form theme in config/packages/twig.yaml if not already present:
      form_themes:
@@ -16,6 +18,6 @@ Next steps:
 Without Symfony Flex, install dependencies manually:
 
   composer require symfony/ux-icons symfony/http-client
-  php bin/console ux:icons:lock tabler:eye tabler:eye-off
+  php bin/console ux:icons:lock
 
 The default widget uses ux_icon(); without these packages icons are omitted (toggle still works).
diff --git a/README.md b/README.md
@@ -147,7 +147,7 @@ When `toggle` is `false`, the field renders as a standard password input without
 
 ```bash
 composer require symfony/ux-icons symfony/http-client
-php bin/console ux:icons:lock tabler:eye tabler:eye-off
+php bin/console ux:icons:lock
 ```
 
 If those packages are missing, the toggle still works but icons are omitted; see [docs/INSTALLATION.md](docs/INSTALLATION.md#missing-icon-packages-runtime-behaviour).
diff --git a/demo/README.md b/demo/README.md
@@ -365,7 +365,7 @@ If Composer reports that the path repository has higher priority but `dev-main`
 Demos require **symfony/ux-icons** and **symfony/http-client** (matching the demo Symfony major). After `composer install`, lock the default tabler icons:
 
 ```bash
-docker-compose exec php php bin/console ux:icons:lock tabler:eye tabler:eye-off
+docker-compose exec php php bin/console ux:icons:lock
 ```
 
 Composer `auto-scripts` in each demo run this on `post-install-cmd` / `post-update-cmd`. If icons are still missing, ensure `assets/icons/tabler/eye.svg` and `eye-off.svg` exist (copy from `.symfony/recipes/nowo-tech/password-toggle-bundle/1.2.3/assets/icons/tabler/` in the bundle repo) and check `config/packages/ux_icons.yaml`.
diff --git a/demo/symfony6/composer.json b/demo/symfony6/composer.json
@@ -65,7 +65,7 @@
         "test-coverage": "phpunit --coverage-html coverage --coverage-clover coverage.xml",
         "auto-scripts": {
             "cache:clear": "symfony-cmd",
-            "ux:icons:lock tabler:eye tabler:eye-off": "symfony-cmd"
+            "ux:icons:lock": "symfony-cmd"
         },
         "post-install-cmd": [
             "@auto-scripts"
diff --git a/demo/symfony7/composer.json b/demo/symfony7/composer.json
@@ -67,7 +67,7 @@
             "cache:clear": "symfony-cmd",
             "assets:install %PUBLIC_DIR%": "symfony-cmd",
             "importmap:install": "symfony-cmd",
-            "ux:icons:lock tabler:eye tabler:eye-off": "symfony-cmd"
+            "ux:icons:lock": "symfony-cmd"
         },
         "post-install-cmd": [
             "@auto-scripts"
diff --git a/demo/symfony8-php85/composer.json b/demo/symfony8-php85/composer.json
@@ -67,7 +67,7 @@
             "cache:clear": "symfony-cmd",
             "assets:install %PUBLIC_DIR%": "symfony-cmd",
             "importmap:install": "symfony-cmd",
-            "ux:icons:lock tabler:eye tabler:eye-off": "symfony-cmd"
+            "ux:icons:lock": "symfony-cmd"
         },
         "post-install-cmd": [
             "@auto-scripts"
diff --git a/demo/symfony8/composer.json b/demo/symfony8/composer.json
@@ -67,7 +67,7 @@
             "cache:clear": "symfony-cmd",
             "assets:install %PUBLIC_DIR%": "symfony-cmd",
             "importmap:install": "symfony-cmd",
-            "ux:icons:lock tabler:eye tabler:eye-off": "symfony-cmd"
+            "ux:icons:lock": "symfony-cmd"
         },
         "post-install-cmd": [
             "@auto-scripts"
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Table of contents
 
 - [[Unreleased]](#unreleased)
+- [[1.2.5] - 2026-06-18](#125---2026-06-18)
 - [[1.2.4] - 2026-06-18](#124---2026-06-18)
 - [[1.2.3] - 2026-04-15](#123---2026-04-15)
 - [[1.2.2] - 2026-03-16](#122---2026-03-16)
@@ -19,6 +20,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.5] - 2026-06-18
+
+### Fixed
+
+- **UX Icons 3.x `ux:icons:lock`**: command accepts no icon arguments (scans Twig templates). Updated docs, demos (`auto-scripts`), recipe `post-install.txt`, `IconSupportChecker` warning message, and dev template hint. Use `php bin/console ux:icons:lock` (optional `--force`).
+
 ## [1.2.4] - 2026-06-18
 
 ### Added
diff --git a/docs/INSTALLATION.md b/docs/INSTALLATION.md
@@ -11,7 +11,7 @@ This guide covers installing Password Toggle Bundle in a Symfony application.
 
 ```bash
 composer require symfony/ux-icons symfony/http-client
-php bin/console ux:icons:lock tabler:eye tabler:eye-off
+php bin/console ux:icons:lock
 ```
 
 ## Install with Composer
@@ -29,9 +29,11 @@ Use a constraint such as `^1.0` to stay on the current major version.
 If you use Symfony Flex, the bundle is registered automatically, configuration is created at `config/packages/nowo_password_toggle.yaml`, **symfony/ux-icons** and **symfony/http-client** are added, and tabler icons are copied under `assets/icons/tabler/`. Run after install:
 
 ```bash
-php bin/console ux:icons:lock tabler:eye tabler:eye-off
+php bin/console ux:icons:lock
 ```
 
+With **UX Icons 3.x**, the command scans Twig templates (no icon names as arguments). Use `--force` to overwrite existing local SVGs.
+
 ### Manual registration
 
 1. **Register the bundle** in `config/bundles.php`:
@@ -73,7 +75,7 @@ return [
    Copy tabler SVGs under `assets/icons/tabler/` (see the Flex recipe in `.symfony/recipes/.../1.2.3/assets/icons/tabler/`) or lock icons after install:
 
    ```bash
-   php bin/console ux:icons:lock tabler:eye tabler:eye-off
+   php bin/console ux:icons:lock
    ```
 
 4. **Create configuration** (optional). Create `config/packages/nowo_password_toggle.yaml` with your preferred defaults. See [CONFIGURATION.md](CONFIGURATION.md) for all options.
@@ -88,7 +90,7 @@ If `symfony/ux-icons` or `symfony/http-client` is not installed:
   - **dev**: toggle works; a small `[icons missing]` hint is shown instead of icons.
   - **prod**: toggle works without icons (no uncaught exception from `ux_icon()`).
 
-To restore icons, install both packages and run `php bin/console ux:icons:lock tabler:eye tabler:eye-off`, or override the form theme to avoid `ux_icon()`.
+To restore icons, install both packages and run `php bin/console ux:icons:lock`, or override the form theme to avoid `ux_icon()`.
 
 ## Next steps
 
diff --git a/docs/RELEASE.md b/docs/RELEASE.md
@@ -3,16 +3,16 @@
 1. Update [CHANGELOG.md](CHANGELOG.md): move entries from `[Unreleased]` to a new `[X.Y.Z] - YYYY-MM-DD` section. (This project does not store version in `composer.json`; Packagist uses the git tag.)
 2. Update [UPGRADING.md](UPGRADING.md) if the release has upgrade notes.
 3. Run pre-release checks: `make release-check` (cs-fix, cs-check, rector-dry, phpstan, test-coverage, and optionally demo healthchecks).
-4. Commit all changes, create an annotated tag (e.g. `v1.2.4`), and push branch and tag. The release workflow will create the GitHub Release with the changelog.
+4. Commit all changes, create an annotated tag (e.g. `v1.2.5`), and push branch and tag. The release workflow will create the GitHub Release with the changelog.
 5. Publish the package to Packagist if applicable (usually automatic when the tag is pushed).
 
-## Example for v1.2.4
+## Example for v1.2.5
 
 ```bash
 git add -A
 git status   # review
-git commit -m "Release 1.2.4: UX Icons detection, Flex recipe, graceful icon fallback"
-git tag -a v1.2.4 -m "Release 1.2.4"
+git commit -m "Release 1.2.5: fix ux:icons:lock for UX Icons 3.x"
+git tag -a v1.2.5 -m "Release 1.2.5"
 git push origin main
-git push origin v1.2.4
+git push origin v1.2.5
 ```
diff --git a/docs/UPGRADING.md b/docs/UPGRADING.md
@@ -4,12 +4,16 @@ This document describes how to upgrade between major versions of Password Toggle
 
 ## 1.x
 
+### 1.2.5
+
+- **UX Icons 3.x:** replace `php bin/console ux:icons:lock tabler:eye tabler:eye-off` with `php bin/console ux:icons:lock` in scripts and CI. The command scans Twig templates; optional `--force` overwrites local SVGs. Demos and Flex recipe post-install are updated in this release.
+
 ### 1.2.4
 
 - **No breaking API changes** for `PasswordType` or `nowo_password_toggle` config.
 - **Recommended:** ensure `symfony/ux-icons` and `symfony/http-client` are installed if you use the default widget. Symfony Flex recipe **1.2.3+** adds both automatically on new installs.
 - **Without those packages:** compile/cache warmup still works; you get a log warning once per process and icons are skipped (see [INSTALLATION.md](INSTALLATION.md#missing-icon-packages-runtime-behaviour)).
-- **Manual upgrade:** `composer require symfony/ux-icons symfony/http-client` then `php bin/console ux:icons:lock tabler:eye tabler:eye-off`.
+- **Manual upgrade:** `composer require symfony/ux-icons symfony/http-client` then `php bin/console ux:icons:lock`.
 
 ### 1.2.3
 
diff --git a/docs/USAGE.md b/docs/USAGE.md
@@ -58,9 +58,11 @@ The bundled widget `toggle_password_widget.html.twig` renders icons with `ux_ico
 Symfony Flex (recipe **1.2.3+**) adds both packages, copies starter SVGs to `assets/icons/tabler/`, and creates `config/packages/ux_icons.yaml`. After install, lock icons for production:
 
 ```bash
-php bin/console ux:icons:lock tabler:eye tabler:eye-off
+php bin/console ux:icons:lock
 ```
 
+With **UX Icons 3.x**, this command scans Twig templates for `ux_icon()` usage (no icon names as CLI arguments). The recipe also ships local tabler SVGs as a fallback before the first lock.
+
 **Without Flex**, install manually — see [Installation](INSTALLATION.md).
 
 **If packages are missing:** the toggle still works; icons are omitted. In **dev** you may see `[icons missing]`; a one-time log warning points to `composer require symfony/ux-icons symfony/http-client`. No compile-time exception.
diff --git a/src/IconSupport/IconSupportChecker.php b/src/IconSupport/IconSupportChecker.php
@@ -63,7 +63,7 @@ public function getActionableWarningMessage(): ?string
         }
 
         return sprintf(
-            'Password Toggle Bundle default icons require %s. Run: composer require %s && php bin/console ux:icons:lock tabler:eye tabler:eye-off',
+            'Password Toggle Bundle default icons require %s. Run: composer require %s && php bin/console ux:icons:lock',
             implode(' and ', $missing),
             implode(' ', $missing),
         );
diff --git a/src/Resources/views/Form/toggle_password_widget.html.twig b/src/Resources/views/Form/toggle_password_widget.html.twig
@@ -58,7 +58,7 @@
             {{ ux_icon(hidden_icon|default('tabler:eye'), {class: 'icon-visible d-none icon-base ti tabler'}) }}
           {%- endif -%}
         {%- elseif app.environment is defined and app.environment == 'dev' -%}
-          <span class="password-toggle-icon-missing text-muted small" title="Run: composer require symfony/ux-icons symfony/http-client &amp;&amp; php bin/console ux:icons:lock tabler:eye tabler:eye-off">[icons missing]</span>
+          <span class="password-toggle-icon-missing text-muted small" title="Run: composer require symfony/ux-icons symfony/http-client &amp;&amp; php bin/console ux:icons:lock">[icons missing]</span>
         {%- endif -%}
       </span>
     </div>
