Bugfix: Extracting data from byte response instead of string#2
Open
mertaksoy wants to merge 1 commit into
Open
Bugfix: Extracting data from byte response instead of string#2mertaksoy wants to merge 1 commit into
mertaksoy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The response of get call looks like this:
{"key": "value}'As you can see there is an apostrophe at the end. This comes because of the wrong conversion of byte to string.
b'HTTP/1.1 200 OK\r\n ............ {"key": "value}'after a lot of splits the apostrophe was forgotten.
This PR extracts data from the upstream without converting it to string.
After the response here, we could followings:
Parsing to string
res = str(httpRes, 'utf-8')and then converting it to jsonjson.loads(res)