Always close connection after reloading types in migration. (#3465)

marcusber · roji · commit e46e43e01d6b · 2025-02-15T19:42:14.000+02:00
Closes #3464 (cherry picked from commit 786b635)
diff --git a/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs b/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs
@@ -83,7 +83,7 @@ public override void Migrate(string? targetMigration = null)
             {
                 npgsqlConnection.ReloadTypes();
             }
-            catch
+            finally
             {
                 _connection.Close();
             }
@@ -130,7 +130,7 @@ public override async Task MigrateAsync(
             {
                 await npgsqlConnection.ReloadTypesAsync().ConfigureAwait(false);
             }
-            catch
+            finally
             {
                 await _connection.CloseAsync().ConfigureAwait(false);
             }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public override void Migrate(string? targetMigration = null)`
`83`	`83`	`{`
`84`	`84`	`npgsqlConnection.ReloadTypes();`
`85`	`85`	`}`
`86`		`- catch`
	`86`	`+ finally`
`87`	`87`	`{`
`88`	`88`	`_connection.Close();`
`89`	`89`	`}`
`@@ -130,7 +130,7 @@ public override async Task MigrateAsync(`
`130`	`130`	`{`
`131`	`131`	`await npgsqlConnection.ReloadTypesAsync().ConfigureAwait(false);`
`132`	`132`	`}`
`133`		`- catch`
	`133`	`+ finally`
`134`	`134`	`{`
`135`	`135`	`await _connection.CloseAsync().ConfigureAwait(false);`
`136`	`136`	`}`