Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Syncs EFCore.PG to EF Core daily build 11.0.0-preview.4.26215.121, updating dependency versions and aligning provider/test code with upstream EF Core API and test surface changes.
Changes:
- Bumped EF Core + Microsoft.Extensions package versions to
11.0.0-preview.4.26215.121. - Simplified
NpgsqlHistoryRepositoryby relying on EF Core’s now-overridableHistoryRepository.EnsureModel(). - Updated/added overrides in functional tests to match new/changed EF Core tests and signatures.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates EF Core and Microsoft.Extensions pinned versions to the new daily build. |
| src/EFCore.PG/Migrations/Internal/NpgsqlHistoryRepository.cs | Removes local EnsureModel() copy and calls the base implementation, keeping history table creation filtering behavior. |
| test/EFCore.PG.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsNpgsqlTest.cs | Adds overrides for newly introduced upstream DateTimeOffset translation tests and baselines/expected failures. |
| test/EFCore.PG.FunctionalTests/Query/PrimitiveCollectionsQueryNpgsqlTest.cs | Adds baseline override for new enum-collection parameter translation test. |
| test/EFCore.PG.FunctionalTests/JsonTypesNpgsqlTest.cs | Updates overridden method signatures to match upstream JSON test changes (added expected parameter). |
| // Cannot override since the base test contains [InlineData] attributes which still apply, and which contain data we need | ||
| // to override. See Can_read_write_nullable_TimeSpan_JSON_values_npgsql instead. | ||
| // TODO: Implement Can_read_write_collection_of_TimeSpan_JSON_values_npgsql | ||
| public override Task Can_read_write_collection_of_TimeSpan_JSON_values() | ||
| public override Task Can_read_write_collection_of_TimeSpan_JSON_values(string expected) | ||
| => Task.CompletedTask; |
There was a problem hiding this comment.
The comment says to see Can_read_write_nullable_TimeSpan_JSON_values_npgsql instead, but no such method exists in this class (and the TODO indicates it’s not implemented yet). This cross-reference is misleading—either implement the referenced *_npgsql test method or update the comment to point at the correct helper/placeholder for the TimeSpan collection case.
| // Cannot override since the base test contains [InlineData] attributes which still apply, and which contain data we need | ||
| // to override. See Can_read_write_nullable_TimeSpan_JSON_values_npgsql instead. | ||
| // TODO: Implement Can_read_write_collection_of_nullable_TimeSpan_JSON_values_npgsql | ||
| public override Task Can_read_write_collection_of_nullable_TimeSpan_JSON_values() | ||
| => Task.CompletedTask; | ||
| public override Task Can_read_write_collection_of_nullable_TimeSpan_JSON_values(string expected) | ||
| => Task.CompletedTask; |
There was a problem hiding this comment.
This comment points to Can_read_write_nullable_TimeSpan_JSON_values_npgsql, but that method isn’t implemented anywhere in this file. Consider updating the comment to reference the intended Can_read_write_collection_of_nullable_TimeSpan_JSON_values_npgsql (if that’s the plan) or adding the missing *_npgsql method so readers know where the provider-specific coverage lives.
Syncs EFCore.PG to use EF Core daily build
11.0.0-preview.4.26215.121(from11.0.0-preview.4.26210.110).Changes
11.0.0-preview.4.26215.121EnsureModel()method — the base classHistoryRepository.EnsureModel()is nowprotected virtualinstead ofprivateDateTime,UtcDateTime,LocalDateTime,ToOffset,Ctor_DateTime,Ctor_DateTime_TimeSpan)Parameter_collection_of_enum_Cast_from_different_enum_typetestCan_read_write_collection_of_TimeSpan_JSON_valuesandCan_read_write_collection_of_nullable_TimeSpan_JSON_values(addedstring expectedparameter)EF Core PRs that required changes
HistoryRepository.EnsureModel()protected virtual)Parameter_collection_of_enum_Cast_from_different_enum_typetest)Test results