Cache alphabetic sort

Author: feelepxyz

lib/commands/audit.js

@@ -16,6 +16,8 @@ const log = require('../utils/log-shim.js')
 const pulseTillDone = require('../utils/pulse-till-done.js')
 const reifyFinish = require('../utils/reify-finish.js')
 
+const sortAlphabetically = (a, b) => localeCompare(a.name, b.name)
+
 const verifySignature = async ({ message, signature, publicKey }) => {
   const verifier = crypto.createVerify('SHA256')
   verifier.write(message)
@@ -63,9 +65,8 @@ class VerifySignatures {
       throw new Error('No dependencies found in current install')
     }
 
-    // Sort alphabetically
-    const invalid = Array.from(this.invalid).sort((a, b) => localeCompare(a.name, b.name))
-    const missing = Array.from(this.missing).sort((a, b) => localeCompare(a.name, b.name))
+    const invalid = Array.from(this.invalid).sort(sortAlphabetically)
+    const missing = Array.from(this.missing).sort(sortAlphabetically)
 
     const verified = invalid.length === 0 && missing.length === 0
 
@@ -307,7 +308,7 @@ class VerifySignatures {
       return `${nameVersion}${suffix}`
     }))
 
-    return uniquePackages.join('\n')
+    return [...uniquePackages].join('\n')
   }
 
   makeJSON ({ invalid, missing }) {