Skip to content

fix: gitlab example for trusted publishing#1710

Merged
wraithgar merged 1 commit into
npm:mainfrom
jrvidal:id_tokens
Sep 10, 2025
Merged

fix: gitlab example for trusted publishing#1710
wraithgar merged 1 commit into
npm:mainfrom
jrvidal:id_tokens

Conversation

@jrvidal

@jrvidal jrvidal commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

I haven't been quite able to make trusted publishing work in GitLab (see npm/cli#8558), but I do think the example is incorrect. id_tokens is not a valid global keyword. It needs to be specified under default or a job. I think a job makes more sense.

Reference:

@wraithgar

Copy link
Copy Markdown
Contributor

Did this approach work for you?

@jrvidal

jrvidal commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Yes:

(The part I haven't made work yet is provenance generation)

@wraithgar

Copy link
Copy Markdown
Contributor

Yes:

That's very good to hear. Provenance is a separate process, so we can merge this now to get it out there.

@wraithgar wraithgar merged commit f4d04c4 into npm:main Sep 10, 2025
8 of 9 checks passed
@jrvidal jrvidal deleted the id_tokens branch November 29, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants