refactor: remove linter warnings (#2063)

Author: MatteoGabriele

.storybook/main.ts

@@ -8,10 +8,10 @@ const config = {
   features: {
     backgrounds: false,
   },
-  async viteFinal(config) {
-    config.plugins ??= []
+  async viteFinal(newConfig) {
+    newConfig.plugins ??= []
 
-    config.plugins.push({
+    newConfig.plugins.push({
       name: 'ignore-internals',
       transform(_, id) {
         if (id.includes('/app/pages/blog/') && id.endsWith('.md')) {
@@ -23,7 +23,7 @@ const config = {
     // vue-docgen-api can crash on components that import types from other
     // .vue files (it tries to parse the SFC with @babel/parser as plain TS).
     // This wrapper catches those errors so the build doesn't fail.
-    const docgenPlugin = config.plugins?.find(
+    const docgenPlugin = newConfig.plugins?.find(
       (p): p is Extract<typeof p, { name: string }> =>
         !!p && typeof p === 'object' && 'name' in p && p.name === 'storybook:vue-docgen-plugin',
     )
@@ -48,7 +48,7 @@ const config = {
       }
     }
 
-    return config
+    return newConfig
   },
 } satisfies StorybookConfig
 

app/components/Compare/FacetBarChart.vue

@@ -178,8 +178,8 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
               bold: false,
               color: colors.value.fg,
               value: {
-                formatter: ({ config }) => {
-                  return config?.datapoint?.formattedValue ?? '0'
+                formatter: ({ config: formatterConfig }) => {
+                  return formatterConfig?.datapoint?.formattedValue ?? '0'
                 },
               },
             },

app/composables/npm/useUserPackages.ts

@@ -47,7 +47,7 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
 
   const asyncData = useLazyAsyncData(
     () => `user-packages:${searchProviderValue.value}:${toValue(username)}`,
-    async ({ $npmRegistry }, { signal }) => {
+    async (_nuxtApp, { signal }) => {
       const user = toValue(username)
       if (!user) {
         return emptySearchResponse()

app/composables/useBlogPostBlueskyLink.ts

@@ -72,6 +72,7 @@ export function useBlogPostBlueskyLink(slug: MaybeRefOrGetter<string | null | un
         // TODO: Will need to remove this console error to satisfy linting scan
         // Constellation unavailable or error - fail silently
         // But during dev we will get an error
+        // oxlint-disable-next-line no-console
         if (import.meta.dev) console.error('[Bluesky] Constellation error:', error)
       }
 

app/composables/useFacetSelection.ts

@@ -6,6 +6,14 @@ export interface FacetInfoWithLabels extends Omit<FacetInfo, 'id'> {
   chartable: boolean
 }
 
+// Get facets in a category (excluding coming soon)
+function getFacetsInCategory(category: string): ComparisonFacet[] {
+  return ALL_FACETS.filter(f => {
+    const info = FACET_INFO[f]
+    return info.category === category && !info.comingSoon
+  })
+}
+
 /**
  * Composable for managing comparison facet selection with URL sync.
  *
@@ -150,14 +158,6 @@ export function useFacetSelection(queryParam = 'facets') {
     }
   }
 
-  // Get facets in a category (excluding coming soon)
-  function getFacetsInCategory(category: string): ComparisonFacet[] {
-    return ALL_FACETS.filter(f => {
-      const info = FACET_INFO[f]
-      return info.category === category && !info.comingSoon
-    })
-  }
-
   // Select all facets in a category
   function selectCategory(category: string): void {
     const categoryFacets = getFacetsInCategory(category)

app/composables/useMarkdown.ts

@@ -88,20 +88,20 @@ function parseMarkdown({ text, packageName, plain }: UseMarkdownOptions): string
   html = html.replace(/~~(.+?)~~/g, '<del>$1</del>')
 
   // Links: [text](url) - only allow https, mailto
-  html = html.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_match, text, url) => {
+  html = html.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_match, textGroup, url) => {
     // In plain mode, just render the link text without the anchor
     if (plain) {
-      return text
+      return textGroup
     }
     const decodedUrl = url.replace(/&amp;/g, '&')
     try {
       const { protocol, href } = new URL(decodedUrl)
       if (['https:', 'mailto:'].includes(protocol)) {
         const safeUrl = href.replace(/"/g, '&quot;')
-        return `<a href="${safeUrl}" rel="nofollow noreferrer noopener" target="_blank">${text}</a>`
+        return `<a href="${safeUrl}" rel="nofollow noreferrer noopener" target="_blank">${textGroup}</a>`
       }
     } catch {}
-    return `${text} (${url})`
+    return `${textGroup} (${url})`
   })
 
   return html

app/pages/search.vue

@@ -393,12 +393,12 @@ const exactMatchType = computed<'package' | 'org' | 'user' | null>(() => {
 const suggestionCount = computed(() => validatedSuggestions.value.length)
 const totalSelectableCount = computed(() => suggestionCount.value + resultCount.value)
 
+const isVisible = (el: HTMLElement) => el.getClientRects().length > 0
+
 /**
  * Get all focusable result elements in DOM order (suggestions first, then packages)
  */
 function getFocusableElements(): HTMLElement[] {
-  const isVisible = (el: HTMLElement) => el.getClientRects().length > 0
-
   const suggestions = Array.from(document.querySelectorAll<HTMLElement>('[data-suggestion-index]'))
     .filter(isVisible)
     .sort((a, b) => {
@@ -435,7 +435,7 @@ async function navigateToPackage(packageName: string) {
 const pendingEnterQuery = shallowRef<string | null>(null)
 
 // Watch for results to navigate when Enter was pressed before results arrived
-watch(displayResults, results => {
+watch(displayResults, newResults => {
   if (!pendingEnterQuery.value) return
 
   // Check if input is still focused (user hasn't started navigating or clicked elsewhere)
@@ -445,7 +445,7 @@ watch(displayResults, results => {
   }
 
   // Navigate if first result matches the query that was entered
-  const firstResult = results[0]
+  const firstResult = newResults[0]
   // eslint-disable-next-line no-console
   console.log('[search] watcher fired', {
     pending: pendingEnterQuery.value,

app/pages/settings.vue

@@ -36,9 +36,9 @@ defineOgImageComponent('Default', {
   primaryColor: '#60a5fa',
 })
 
-const setLocale: typeof setNuxti18nLocale = locale => {
-  settings.value.selectedLocale = locale
-  return setNuxti18nLocale(locale)
+const setLocale: typeof setNuxti18nLocale = newLocale => {
+  settings.value.selectedLocale = newLocale
+  return setNuxti18nLocale(newLocale)
 }
 </script>
 

app/utils/download-anomalies.ts

@@ -98,7 +98,7 @@ export function applyBlocklistCorrection(opts: {
   if (!anomalies.length) return data
 
   // Clone to avoid mutation
-  const result = (data as Array<Record<string, any>>).map(d => ({ ...d }))
+  const result = (data as Array<Record<string, any>>).map(d => Object.assign({}, d))
 
   for (const anomaly of anomalies) {
     // Find indices of affected points

cli/src/mock-state.ts

@@ -229,10 +229,10 @@ export class MockConnectorStateManager {
   }
 
   approveOperation(id: string): PendingOperation | null {
-    const op = this.state.operations.find(op => op.id === id)
-    if (!op || op.status !== 'pending') return null
-    op.status = 'approved'
-    return op
+    const operation = this.state.operations.find(op => op.id === id)
+    if (!operation || operation.status !== 'pending') return null
+    operation.status = 'approved'
+    return operation
   }
 
   approveAll(): number {
@@ -247,11 +247,11 @@ export class MockConnectorStateManager {
   }
 
   retryOperation(id: string): PendingOperation | null {
-    const op = this.state.operations.find(op => op.id === id)
-    if (!op || op.status !== 'failed') return null
-    op.status = 'approved'
-    op.result = undefined
-    return op
+    const operation = this.state.operations.find(op => op.id === id)
+    if (!operation || operation.status !== 'failed') return null
+    operation.status = 'approved'
+    operation.result = undefined
+    return operation
   }
 
   /** Execute all approved operations (mock: instant success unless configured otherwise). */