Skip to content

Commit 87cf141

Browse files
authored
revert: revert "fix: consistent and likely safer regex escaping" (#2403)
1 parent a2948d7 commit 87cf141

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
"@iconify-json/svg-spinners": "1.2.4",
5858
"@iconify-json/vscode-icons": "1.2.45",
5959
"@intlify/shared": "11.3.0",
60-
"@li/regexp-escape-polyfill": "jsr:0.3.4",
6160
"@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@904b935",
6261
"@napi-rs/canvas": "0.1.97",
6362
"@nuxt/a11y": "1.0.0-alpha.1",

pnpm-lock.yaml

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shared/utils/dev-dependency.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { regExpEscape } from '@li/regexp-escape-polyfill'
2-
31
export type DevDependencySuggestionReason = 'known-package' | 'readme-hint'
42

53
export interface DevDependencySuggestion {
@@ -61,11 +59,15 @@ function isKnownDevDependencyPackage(packageName: string): boolean {
6159
)
6260
}
6361

62+
function escapeRegExp(text: string): string {
63+
return text.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
64+
}
65+
6466
function hasReadmeDevInstallHint(packageName: string, readmeContent?: string | null): boolean {
6567
if (!readmeContent) return false
6668

67-
const escapedName = regExpEscape(packageName)
68-
const escapedNpmName = regExpEscape(`npm:${packageName}`)
69+
const escapedName = escapeRegExp(packageName)
70+
const escapedNpmName = escapeRegExp(`npm:${packageName}`)
6971
const packageSpec = `(?:${escapedName}|${escapedNpmName})(?:@[\\w.-]+)?`
7072

7173
const patterns = [

shared/utils/emoji.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { regExpEscape } from '@li/regexp-escape-polyfill'
2-
31
// copied from https://github.com/markdown-it/markdown-it-emoji/blob/master/lib/data/full.mjs
42
const emojis = {
53
'100': '💯',
@@ -1909,7 +1907,7 @@ const emojis = {
19091907

19101908
const emojisKeysRegex = new RegExp(
19111909
Object.keys(emojis)
1912-
.map(key => `:${regExpEscape(key)}:`)
1910+
.map(key => `:${key}:`)
19131911
.join('|'),
19141912
'g',
19151913
)

0 commit comments

Comments
 (0)