Skip to content

Commit c5b3b0f

Browse files
feat: replace quadrant with scatter with selectable axes (#2472)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
1 parent 925bf16 commit c5b3b0f

28 files changed

+1868
-1798
lines changed

app/components/Chart/SplitSparkline.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ const configs = computed(() => {
244244

245245
<template #skeleton>
246246
<!-- This empty div overrides the default built-in scanning animation on load -->
247-
<div />
247+
<div></div>
248248
</template>
249249
</VueUiSparkline>
250250
</div>

app/components/Compare/FacetBarChart.vue

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,9 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
170170
style: {
171171
chart: {
172172
backgroundColor: colors.value.bg,
173+
legend: {
174+
show: false,
175+
},
173176
},
174177
},
175178
},
@@ -278,7 +281,7 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
278281

279282
<template>
280283
<div class="font-mono facet-bar">
281-
<ClientOnly v-if="dataset.length">
284+
<ClientOnly v-if="packages.length">
282285
<VueUiHorizontalBar :key="chartKey" :dataset :config class="[direction:ltr]">
283286
<template #hint="{ isVisible }">
284287
<p v-if="isVisible" class="text-accent text-xs pt-2" aria-hidden="true">
@@ -339,40 +342,25 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
339342
aria-hidden="true"
340343
/>
341344
</template>
342-
</VueUiHorizontalBar>
343345

344-
<template #fallback>
345-
<div class="flex flex-col gap-2 justify-center items-center mb-2">
346-
<SkeletonInline class="h-4 w-16" />
347-
<SkeletonInline class="h-4 w-28" />
348-
</div>
349-
<div class="flex flex-col gap-1">
350-
<SkeletonInline class="h-7 w-full" v-for="pkg in packages" :key="pkg" />
351-
</div>
352-
</template>
346+
<template #skeleton>
347+
<!-- This empty div overrides the default built-in scanning animation on load -->
348+
<div></div>
349+
</template>
350+
</VueUiHorizontalBar>
353351
</ClientOnly>
354-
355-
<template v-else>
356-
<div class="flex flex-col gap-2 justify-center items-center mb-2">
357-
<SkeletonInline class="h-4 w-16" />
358-
<SkeletonInline class="h-4 w-28" />
359-
</div>
360-
<div class="flex flex-col gap-1">
361-
<SkeletonInline class="h-7 w-full" v-for="pkg in packages" :key="pkg" />
362-
</div>
363-
</template>
364352
</div>
365353
</template>
366354

367355
<style scoped>
368356
:deep(.vue-data-ui-component svg:focus-visible) {
369-
outline: 1px solid var(--accent-color) !important;
357+
outline: 1px solid var(--accent) !important;
370358
border-radius: 0.1rem;
371359
outline-offset: 3px !important;
372360
}
373361
:deep(.vue-ui-user-options-button:focus-visible),
374362
:deep(.vue-ui-user-options :first-child:focus-visible) {
375-
outline: 0.1rem solid var(--accent-color) !important;
363+
outline: 0.1rem solid var(--accent) !important;
376364
border-radius: 0.25rem;
377365
}
378366
</style>

0 commit comments

Comments
 (0)