Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
changed operations to "opdrachten"
|
What's the progress on this? No pressure, just curious! |
I'm still translating and getting further and further but my time is split between this pr, #1233, work and personal life. I'll add an overview at the pr description to get a better indication how far the translations are |
also corrected 'je; -> u/uw (informal -> formal)
|
just temporarily disabled the "Allow edits and access to secrets by maintainers ", this is mostly due to autofix bot which when sync back can cause merge conflicts. When open for review it'll be enabled again. |
No worries! If it helps we can always merge this partially translated, and then you (and/or others) can contribute more in follow up PRs - but it's up to you! |
removed privacy policy & vacation (diff pr)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded Dutch language support by registering a base Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ghostdevv I've just translated the last things I think should be translated for this pr.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@i18n/locales/nl.json`:
- Line 365: The "not_found_message" translation contains a typo ("nit"); update
its value to correct Dutch ("Dit pakket kon niet gevonden worden.") and scan the
other high-visibility keys referenced in the comment (the other locale entries
at the given positions) for similar misspellings—replace "nit" with "niet" and
fix any other spelling/wording mistakes found so that all user-facing strings
read correctly in Dutch.
- Line 1133: The localization key "view_profile" in nl.json uses the Dutch token
"{naam}" which doesn't match the expected interpolation token "{name}" used by
callers; update the value for "view_profile" to use "{name}" so runtime
interpolation works (locate the "view_profile" entry and replace "{naam}" with
"{name}").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 422cfe62-24cd-4e68-999c-baf65fc18616
📒 Files selected for processing (3)
config/i18n.tsi18n/locales/nl-NL.jsoni18n/locales/nl.json
2 participants
📚 Description
Adding Dutch translations to npmx, I've also added nl as a language that has variants because of Flemish.
🧭 Context
This pr adds Dutch to the available languages, in case of "you" I've chosen for the formal variant ("u") instead of informal "je/jij"
terms usage (🇬🇧 = 🇳🇱)
Translations that stay the same because these are already used by Dutch developers as is and because the direct translations don't fit the context of npmx & developing software.
🤖 AI & translator use
I did use Chatgpt, Gemini & Deepl to assist translating while going over each page & translation individually to get the best translations
progress
Below is the progress of translating
scatter_chart)