Skip to content

fix(ui): strip .git before path/query/fragment in normalizeGitUrl #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Mar 23, 2026
Merged

fix(ui): strip .git before path/query/fragment in normalizeGitUrl #2235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee124d3
fix(shared): strip .git before path/query/fragment in normalizeGitUrl
tinsever Mar 23, 2026
d2f11e8
Merge branch 'main' into fix/issue-2233-broken-github-source-links-fo…
ghostdevv Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/utils/git-providers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export function normalizeGitUrl(input: string): string | null {
const url = input
.trim()
.replace(/^git\+/, '')
.replace(/\.git$/, '')
.replace(/\.git(?=[/#?]|$)/i, '')
.replace(/(^|\/)[^/]+?@/, '$1') // remove "user@" from "ssh://user@host.com:..."
.replace(/(\.[^./]+?):/, '$1/') // change ".com:" to ".com/" from "ssh://user@host.com:..."
.replace(/^git:\/\//, 'https://')
Expand Down
6 changes: 6 additions & 0 deletions test/unit/shared/utils/git-providers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ describe('normalizeGitUrl', () => {
expect
.soft(normalizeGitUrl('https://bitbucket.org/user/repo.git'))
.toBe('https://bitbucket.org/user/repo')
expect
.soft(normalizeGitUrl('git+https://github.com/user/repo.git#readme'))
.toBe('https://github.com/user/repo#readme')
expect
.soft(normalizeGitUrl('git+https://github.com/user/repo.git?path=packages/core'))
.toBe('https://github.com/user/repo?path=packages/core')
})

it('should convert git:// protocol to https://', () => {
Expand Down
Loading