Skip to content

feat: add link to socket.dev#2370

Open
gameroman wants to merge 2 commits intonpmx-dev:mainfrom
gameroman:socket.dev
Open

feat: add link to socket.dev#2370
gameroman wants to merge 2 commits intonpmx-dev:mainfrom
gameroman:socket.dev

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

🔗 Linked issue

Closes #2369

🧭 Context

Similar to what npmjs has

image

📚 Description

Adds link to socket.dev

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 7, 2026 7:21am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 7, 2026 7:21am
npmx-lunaria Ignored Ignored Apr 7, 2026 7:21am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4bce1a54-500d-46d1-905c-b97d17e788f0

📥 Commits

Reviewing files that changed from the base of the PR and between 0171632 and 2d07da8.

📒 Files selected for processing (3)
  • app/components/Package/ExternalLinks.vue
  • i18n/locales/en.json
  • i18n/schema.json
✅ Files skipped from review due to trivial changes (2)
  • i18n/locales/en.json
  • app/components/Package/ExternalLinks.vue

📝 Walkthrough

Walkthrough

This pull request adds an always-rendered external link entry to the Package ExternalLinks component that points to https://socket.dev/npm/package/${pkg.name}. The entry displays the localized title $t('common.view_on.socket_dev'), uses the icon class i-simple-icons:socket, and shows the link text socket.dev. No existing link conditions, structure or exported/public signatures were changed; corresponding i18n locale and schema entries for common.view_on.socket_dev were added.

Possibly related PRs

Suggested labels

idea

Suggested reviewers

  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset by describing the addition of a socket.dev link to the package page, consistent with the code changes.
Linked Issues check ✅ Passed The pull request successfully implements the requirement from issue #2369 to add socket.dev links, mirroring npmjs.com's integration through a new external link entry.
Out of Scope Changes check ✅ Passed All changes are directly scoped to implementing the socket.dev link feature: component modification, translation addition, and schema update are all necessary and within scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman marked this pull request as draft April 4, 2026 09:14
@gameroman gameroman marked this pull request as ready for review April 7, 2026 07:19
@gameroman gameroman requested a review from ghostdevv April 7, 2026 07:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/ExternalLinks.vue 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add links to socket.dev

2 participants