Skip to content

feat: use useVisibleItems in DeprecatedTree #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
43081j wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

feat: use useVisibleItems in DeprecatedTree #2399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/components/Package/DeprecatedTree.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ const { data: analysisData, status } = useDependencyAnalysis(
)

const isExpanded = shallowRef(false)
const showAll = shallowRef(false)

const {
visibleItems: visiblePackages,
hasMore: hasMorePackages,
expand: expandPackages,
} = useVisibleItems(() => analysisData.value?.deprecatedPackages ?? [], 5)

const hasDeprecated = computed(
() => analysisData.value?.deprecatedPackages && analysisData.value.deprecatedPackages.length > 0,
Expand Down Expand Up @@ -72,7 +77,7 @@ function getDepthStyle(depth: DependencyDepth) {
>
<ul class="divide-y divide-border list-none m-0 p-0">
<li
v-for="pkg in analysisData!.deprecatedPackages.slice(0, showAll ? undefined : 5)"
v-for="pkg in visiblePackages"
:key="`${pkg.name}@${pkg.version}`"
class="px-4 py-3"
:class="getDepthStyle(pkg.depth).bg"
Expand All @@ -96,10 +101,10 @@ function getDepthStyle(depth: DependencyDepth) {
</ul>

<button
v-if="analysisData!.deprecatedPackages.length > 5 && !showAll"
v-if="hasMorePackages"
type="button"
class="w-full px-4 py-2 text-xs font-mono text-fg-muted hover:text-fg border-t border-border transition-colors duration-200"
@click="showAll = true"
@click="expandPackages"
>
{{
$t('package.deprecated.show_all', { count: analysisData!.deprecatedPackages.length })
Expand Down
Loading