-
-
Notifications
You must be signed in to change notification settings - Fork 425
feat: provide rss, atom and json feeds for the blog #2562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e620cb1
9b3fd46
995a5bb
38fdefe
764b2ac
c8a0147
034ffd6
021d241
4ad82dc
4f8a193
71390b1
0feba05
cfdb1a5
74b2c73
4d27065
453ceb5
1389051
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,6 +133,7 @@ | |
| "devalue": "5.6.4", | ||
| "eslint-plugin-regexp": "3.1.0", | ||
| "fast-check": "4.6.0", | ||
| "feed": "5.2.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Confirm the feed package is only used behind prerendered routes and nowhere on a runtime path.
rg -nP "from ['\"]feed['\"]|require\(['\"]feed['\"]\)" --type=ts --type=js --type=vue
echo '---'
# Double-check no non-prerendered route imports getFeed
rg -nP -C2 "getFeed\s*\(" --type=tsRepository: npmx-dev/npmx.dev Length of output: 992 🏁 Script executed: # Check where feed is imported in feeds.ts
cat -n server/utils/feeds.ts | head -20
echo '=== Checking nuxt.config.ts for prerender settings ==='
# Search for prerender configurations for the feed routes
rg -nP "atom\.xml|rss\.xml|feed\.json" nuxt.config.ts
echo '=== Current package.json state for feed ==='
# Check where feed is currently placed in package.json
rg -nP -B2 -A2 '"feed":\s*"5\.2\.0"' package.json
echo '=== Searching for any other getFeed or feed imports ==='
# Broader search for any other getFeed invocations
rg -nP "getFeed" --type=tsRepository: npmx-dev/npmx.dev Length of output: 1513 🏁 Script executed: # View the prerender configuration for the feed routes in nuxt.config.ts
sed -n '193,210p' nuxt.config.tsRepository: npmx-dev/npmx.dev Length of output: 693 Move
🤖 Prompt for AI Agents |
||
| "h3": "1.15.8", | ||
| "h3-next": "npm:h3@2.0.1-rc.16", | ||
| "knip": "6.0.5", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 1546
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 1250
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 230
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 6315
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 441
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 151
The esbuild
excluderegex pattern will not match the generated blog posts path — the file will remain excluded and builds will fail.The pattern expects the path
node_modules/.cache/nuxt/.nuxt/blog/posts.ts, but Nuxt's defaultbuildDiris.nuxtat the project root. The generated file will be at.nuxt/blog/posts.ts, which does not match the regex and will still be caught by esbuild's defaultnode_modulesexclusion. Sinceserver/utils/feeds.tsimports from#blog/posts, this will cause build failures at runtime.Two actions needed:
.nuxt/blog/posts.tsinstead, orbuildDirpath at build time to catch mismatches immediately.Also, update the comment's file path to use forward slashes consistently:
server/utils/feeds.ts(the regex and actual Linux/macOS paths use/, not Windows-style\).🤖 Prompt for AI Agents