Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe icon mapping for the LICENSE family of filenames (including LICENSE, LICENSE.md, LICENSE.txt, and their lowercase variants) is updated from Changes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/utils/file-icons.ts`:
- Around line 267-272: The FILENAME_ICONS mapping currently forces all LICENSE
variants to the generic icon; change it to only override extensionless LICENSE
names so extension-based fallbacks still apply: remove the keys 'LICENSE.md',
'LICENSE.txt', 'license.md', and 'license.txt' from the mapping in
app/utils/file-icons.ts (leave 'LICENSE' and 'license' if you want to target
only extensionless files), so getFileIcon's extension-based logic will return
markdown/text icons for .md/.txt files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 53cb6251-b574-440a-bb23-eb800880cce9
📒 Files selected for processing (2)
app/utils/file-icons.tstest/unit/app/utils/file-icons.spec.ts
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I don't think this is actually implementing the issue as-intended? |
gioboa
left a comment
There was a problem hiding this comment.
Would it be possible to show a file icon for it?
Based on this description, I implemented it. Let me know if it's a different thing @nicolo-ribaudo
ghostdevv
left a comment
There was a problem hiding this comment.
hey, thank you for the PR! unfortunately, I think the issue was that the icon isn't showing up not that it should use the default file type. I had a look into why it's not showing up but haven't figured it out yet. Will close this for now and post my findings in the original issue 🙏
|
Thanks @ghostdevv for your review 🙏 |
🔗 Linked issue
Close #2558
📚 Description
Use file icon for LICENSE files.
Before:
After:
Before creating the pull request, please make sure you do the following: