Skip to content

perf: prevent duplicates in file tree sprite #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Apr 20, 2026
Merged

perf: prevent duplicates in file tree sprite #2586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397165b
perf: prevent duplicates in file tree sprite
ghostdevv Apr 19, 2026
62f5688
refactor: top level await
ghostdevv Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 21 additions & 29 deletions scripts/generate-file-tree-sprite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ function buildSprite(
let symbols = ''
Object.entries(grouped).forEach(([prefix, iconNames]) => {
const collection = collections[prefix]

if (!collection?.icons) return

const defaultWidth = collection.width ?? 16
const defaultHeight = collection.height ?? 16

iconNames.forEach(name => {
new Set(iconNames).forEach(name => {
const icon = collection.icons[name]

if (!icon?.body) return
Expand All @@ -70,30 +69,23 @@ function buildSprite(
return `<svg xmlns="http://www.w3.org/2000/svg" style="display:none">${symbols}</svg>\n`
}

async function main() {
const collections = await loadCollections()
const iconNames = [
...Object.values(EXTENSION_ICONS),
...Object.values(FILENAME_ICONS),
...Object.values(COMPOUND_EXTENSIONS),
...Object.values(ADDITIONAL_ICONS),
DEFAULT_ICON,
]
const grouped = groupByCollection(iconNames)
const sprite = buildSprite(grouped, collections)
await Promise.all([
fs.mkdir(path.dirname(outputDevPath), { recursive: true }),
fs.mkdir(path.dirname(outputStagePath), { recursive: true }),
fs.mkdir(path.dirname(outputProdPath), { recursive: true }),
])
await Promise.all([
fs.writeFile(outputDevPath, sprite, 'utf8'),
fs.writeFile(outputStagePath, sprite, 'utf8'),
fs.writeFile(outputProdPath, sprite, 'utf8'),
])
}

main().catch(error => {
console.error(error)
process.exitCode = 1
})
const collections = await loadCollections()
const iconNames = [
...Object.values(EXTENSION_ICONS),
...Object.values(FILENAME_ICONS),
...Object.values(COMPOUND_EXTENSIONS),
...Object.values(ADDITIONAL_ICONS),
DEFAULT_ICON,
]
const grouped = groupByCollection(iconNames)
const sprite = buildSprite(grouped, collections)
await Promise.all([
fs.mkdir(path.dirname(outputDevPath), { recursive: true }),
fs.mkdir(path.dirname(outputStagePath), { recursive: true }),
fs.mkdir(path.dirname(outputProdPath), { recursive: true }),
])
await Promise.all([
fs.writeFile(outputDevPath, sprite, 'utf8'),
fs.writeFile(outputStagePath, sprite, 'utf8'),
fs.writeFile(outputProdPath, sprite, 'utf8'),
])
Loading