Skip to content

fix(ui): add loading state for translation status generated time #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Apr 20, 2026
+10 −18
Merged

fix(ui): add loading state for translation status generated time #2589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2413d58
fix(ui): add loading state for translation status generated time
cylewaitforit Apr 20, 2026
871d367
chore: tweak width
ghostdevv Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions app/pages/translation-status.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ defineOgImage(
{ alt: () => `${$t('translation_status.title')} — npmx` },
)

const nuxt = useNuxtApp()
const router = useRouter()
const canGoBack = useCanGoBack()
const { fetchStatus, status } = useI18nStatus()
Expand All @@ -28,14 +27,7 @@ const isLoading = computed<boolean>(
() => fetchStatus.value === 'idle' || fetchStatus.value === 'pending',
)

const generatedAt = computed(() => {
const gat = status.value?.generatedAt
if (import.meta.client) {
return (nuxt.isHydrated ? new Date().toISOString() : gat) ?? new Date().toISOString()
}

return gat ?? new Date().toISOString()
})
const generatedAt = computed(() => status.value?.generatedAt)

const localeEntries = computed<I18nLocaleStatus[]>(() => status.value?.locales || [])

Expand Down Expand Up @@ -68,16 +60,16 @@ ${template}`
<span class="sr-only sm:not-sr-only">{{ $t('nav.back') }}</span>
</button>
</div>
<i18n-t
keypath="translation_status.generated_at"
tag="p"
scope="global"
class="text-fg-muted text-lg"
>
<template #date>
<NuxtTime :locale :datetime="generatedAt" date-style="long" time-style="medium" />
<p class="text-fg-muted text-lg">
<template v-if="isLoading || !generatedAt">
<SkeletonInline class="h-6 w-96" />
</template>
</i18n-t>
<i18n-t v-else keypath="translation_status.generated_at" tag="span" scope="global">
<template #date>
<NuxtTime :locale :datetime="generatedAt" date-style="long" time-style="medium" />
</template>
</i18n-t>
</p>
</header>

<p class="text-fg-muted leading-relaxed mb-4">
Expand Down
Loading