Skip to content

fix: hide mobile search field on blur #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Jun 5, 2026
Merged

fix: hide mobile search field on blur #2852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416555b
fix: hide mobile search field on blur
alexdln Jun 4, 2026
4d8385f
chore: apply suggestion
alexdln Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ useShortcuts({
<!-- Mobile: Search button (expands search) -->
<ButtonBase
type="button"
class="sm:hidden ms-auto"
class="sm:hidden ms-auto py-2.5!"
:aria-label="$t('nav.tap_to_search')"
:aria-expanded="showMobileMenu"
@click="expandMobileSearch"
Expand All @@ -338,7 +338,7 @@ useShortcuts({
<!-- Mobile: Menu button (always visible, click to open menu) -->
<ButtonBase
type="button"
class="sm:hidden"
class="sm:hidden py-2.5!"
:aria-label="$t('nav.open_menu')"
:aria-expanded="showMobileMenu"
@click="showMobileMenu = !showMobileMenu"
Expand Down
15 changes: 11 additions & 4 deletions app/components/Header/SearchBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,17 @@ function clearSearch() {

// Expose focus method for parent components
const inputRef = useTemplateRef('inputRef')
function focus() {
function handleFocus() {
isSearchFocused.value = true
inputRef.value?.focus()
emit('focus')
}
defineExpose({ focus })
function handleBlur() {
isSearchFocused.value = false
inputRef.value?.blur()
emit('blur')
}
defineExpose({ focus: handleFocus, blur: handleBlur })
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
</script>
<template>
<search v-if="showSearchBar" :class="'flex-1 sm:max-w-md ' + inputClass">
Expand All @@ -60,8 +67,8 @@ defineExpose({ focus })
:placeholder="$t('search.placeholder')"
no-correct
class="w-full min-w-25 ps-7 pe-8"
@focus="isSearchFocused = true"
@blur="isSearchFocused = false"
@focus="handleFocus"
@blur="handleBlur"
size="sm"
ariaKeyshortcuts="/"
/>
Expand Down
Loading