test: move cases to resolveUpgradeTargetVersion

Author: 9romise

tests/diagnostics/upgrade.test.ts

@@ -20,56 +20,25 @@ function createUpgradeContext(version: string) {
 }
 
 describe('checkUpgrade', () => {
-  it('should flag when latest is greater than current version', async () => {
-    const ctx = createUpgradeContext('^1.0.0')
-    const result = await checkUpgrade(ctx)
+  it('should create upgrade diagnostic payload', async () => {
+    const result = await checkUpgrade(createUpgradeContext('^1.0.0'))
 
     expect(result).toBeDefined()
     expect(result!.code).toMatchObject({ value: 'upgrade' })
-    expect(result!.message).toContain('2.7.0')
+    expect(result!.message).toMatchInlineSnapshot('"New version available: ^2.7.0"')
   })
 
-  it('should not flag when already on latest', async () => {
-    const ctx = createUpgradeContext('^2.7.0')
-    const result = await checkUpgrade(ctx)
-
-    expect(result).toBeUndefined()
-  })
-
-  it('should not flag when version is a dist tag', async () => {
-    const ctx = createUpgradeContext('latest')
-    const result = await checkUpgrade(ctx)
-
-    expect(result).toBeUndefined()
-  })
-
-  it('should not flag when version is a dist tag with protocol', async () => {
-    const ctx = createUpgradeContext('npm:latest')
-    const result = await checkUpgrade(ctx)
-
-    expect(result).toBeUndefined()
-  })
-
-  it('should flag prerelease upgrade within same pre-id', async () => {
-    const ctx = createUpgradeContext('3.0.0-alpha.1')
-    const result = await checkUpgrade(ctx)
+  it('should preserve protocol prefix in diagnostic message', async () => {
+    const result = await checkUpgrade(createUpgradeContext('npm:^1.0.0'))
 
     expect(result).toBeDefined()
-    expect(result!.message).toContain('3.0.0-alpha.5')
+    expect(result!.code).toMatchObject({ value: 'upgrade' })
+    expect(result!.message).toMatchInlineSnapshot('"New version available: npm:^2.7.0"')
   })
 
-  it('should not flag prerelease when already on latest pre-id version', async () => {
-    const ctx = createUpgradeContext('3.0.0-alpha.5')
-    const result = await checkUpgrade(ctx)
+  it('should return undefined for unsupported protocol', async () => {
+    const result = await checkUpgrade(createUpgradeContext('workspace:^1.0.0'))
 
     expect(result).toBeUndefined()
   })
-
-  it('should preserve protocol prefix in message', async () => {
-    const ctx = createUpgradeContext('npm:^1.0.0')
-    const result = await checkUpgrade(ctx)
-
-    expect(result).toBeDefined()
-    expect(result!.message).toContain('npm:^2.7.0')
-  })
 })

tests/utils/upgrade.test.ts

@@ -0,0 +1,27 @@
+import type { PackageInfo } from '#utils/api/package'
+import { describe, expect, it } from 'vitest'
+import { resolveUpgradeTargetVersion } from '../../src/utils/upgrade'
+
+function createPackageInfo(distTags: Record<string, string>): PackageInfo {
+  return {
+    distTags,
+  } as PackageInfo
+}
+
+describe('resolveUpgradeTargetVersion', () => {
+  const pkg = createPackageInfo({
+    latest: '2.7.0',
+    next: '3.0.0-alpha.5',
+    beta: '3.0.0-beta.3',
+  })
+
+  it.each([
+    { exactVersion: '1.0.0', expected: '2.7.0' },
+    { exactVersion: '2.7.0', expected: undefined },
+    { exactVersion: '3.0.0-alpha.1', expected: '3.0.0-alpha.5' },
+    { exactVersion: '3.0.0-alpha.5', expected: undefined },
+    { exactVersion: '3.0.0-rc.1', expected: undefined },
+  ])('should resolve target for $exactVersion to $expected', ({ exactVersion, expected }) => {
+    expect(resolveUpgradeTargetVersion(pkg, exactVersion)).toBe(expected)
+  })
+})