refactor: extract resolveUpgradeTargetVersion

Author: 9romise

src/providers/diagnostics/rules/upgrade.ts

@@ -1,14 +1,17 @@
-import type { DependencyInfo } from '#types/extractor'
-import type { ParsedVersion } from '#utils/version'
-import type { DiagnosticRule, NodeDiagnosticInfo } from '..'
+import type { DiagnosticRule } from '..'
 import { npmxPackageUrl } from '#utils/links'
+import { resolveUpgradeTargetVersion } from '#utils/upgrade'
 import { formatUpgradeVersion } from '#utils/version'
-import gt from 'semver/functions/gt'
-import lte from 'semver/functions/lte'
-import prerelease from 'semver/functions/prerelease'
 import { DiagnosticSeverity, Uri } from 'vscode'
 
-function createUpgradeDiagnostic(dep: DependencyInfo, parsed: ParsedVersion, target: string): NodeDiagnosticInfo {
+export const checkUpgrade: DiagnosticRule = ({ dep, pkg, parsed, exactVersion }) => {
+  if (!parsed || !exactVersion)
+    return
+
+  const target = resolveUpgradeTargetVersion(pkg, exactVersion)
+  if (!target)
+    return
+
   return {
     node: dep.versionNode,
     severity: DiagnosticSeverity.Hint,
@@ -19,30 +22,3 @@ function createUpgradeDiagnostic(dep: DependencyInfo, parsed: ParsedVersion, tar
     },
   }
 }
-
-export const checkUpgrade: DiagnosticRule = ({ dep, pkg, parsed, exactVersion }) => {
-  if (!parsed || !exactVersion)
-    return
-
-  if (Object.hasOwn(pkg.distTags, exactVersion))
-    return
-
-  const { latest } = pkg.distTags
-  if (gt(latest, exactVersion))
-    return createUpgradeDiagnostic(dep, parsed, latest)
-
-  const currentPreId = prerelease(exactVersion)?.[0]
-  if (currentPreId == null)
-    return
-
-  for (const [tag, tagVersion] of Object.entries(pkg.distTags)) {
-    if (tag === 'latest')
-      continue
-    if (prerelease(tagVersion)?.[0] !== currentPreId)
-      continue
-    if (lte(tagVersion, exactVersion))
-      continue
-
-    return createUpgradeDiagnostic(dep, parsed, tagVersion)
-  }
-}

src/utils/upgrade.ts

@@ -0,0 +1,32 @@
+import type { PackageInfo } from '#utils/api/package'
+import gt from 'semver/functions/gt'
+import lte from 'semver/functions/lte'
+import prerelease from 'semver/functions/prerelease'
+
+/**
+ * Resolve the next upgrade target from npm dist-tags based on current exact version.
+ * Mirrors the existing diagnostics upgrade rule behavior so other providers can reuse it.
+ */
+export function resolveUpgradeTargetVersion(pkg: PackageInfo, exactVersion: string): string | undefined {
+  if (Object.hasOwn(pkg.distTags, exactVersion))
+    return
+
+  const { latest } = pkg.distTags
+  if (gt(latest, exactVersion))
+    return latest
+
+  const currentPreId = prerelease(exactVersion)?.[0]
+  if (currentPreId == null)
+    return
+
+  for (const [tag, tagVersion] of Object.entries(pkg.distTags)) {
+    if (tag === 'latest')
+      continue
+    if (prerelease(tagVersion)?.[0] !== currentPreId)
+      continue
+    if (lte(tagVersion, exactVersion))
+      continue
+
+    return tagVersion
+  }
+}