Skip to content

fix: handle windows paths in umd-to-esm #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RYGRIT wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Open

fix: handle windows paths in umd-to-esm #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a269e87
fix: handle windows paths in umd-to-esm
RYGRIT Apr 10, 2026
5ca8f8c
fix: fallback when importer is missing
RYGRIT Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions plugins/umd-to-esm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ const targets = [
/^jsonc-parser$/,
]

const UMD_SEGMENT_PATTERN = /[/\\]umd[/\\]/

export function toEsmPath(resolvedModulePath: string) {
return resolvedModulePath.replace(UMD_SEGMENT_PATTERN, (matchedSegment) => matchedSegment.replace('umd', 'esm'))
}

export function umdToEsm(): Rolldown.RolldownPlugin {
return {
name: 'umd-to-esm',
Expand All @@ -15,10 +21,10 @@ export function umdToEsm(): Rolldown.RolldownPlugin {
id: targets,
},
handler(source, importer) {
const require = createRequire(importer!)
const pathUmdMay = require.resolve(source)
const pathEsm = pathUmdMay.replace('/umd/', '/esm/')
return { id: pathEsm }
const require = createRequire(importer ?? import.meta.url)
const resolvedModulePath = require.resolve(source)
const resolvedEsmPath = toEsmPath(resolvedModulePath)
return { id: resolvedEsmPath }
},
},
}
Expand Down
Loading