API: libcrmcommon: Deprecate crm_element_value_ll()

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>

Author: nrwahl2

include/crm/common/xml_element.h

@@ -35,7 +35,6 @@ const char *crm_xml_add_timeval(xmlNode *xml, const char *name_sec,
 
 const char *crm_element_value(const xmlNode *data, const char *name);
 int crm_element_value_int(const xmlNode *data, const char *name, int *dest);
-int crm_element_value_ll(const xmlNode *data, const char *name, long long *dest);
 char *crm_element_value_copy(const xmlNode *data, const char *name);
 
 #ifdef __cplusplus

include/crm/common/xml_element_compat.h

@@ -51,6 +51,10 @@ int crm_element_value_epoch(const xmlNode *xml, const char *name, time_t *dest);
 //! \deprecated Do not use
 int crm_element_value_ms(const xmlNode *data, const char *name, guint *dest);
 
+//! \deprecated Do not use
+int crm_element_value_ll(const xmlNode *data, const char *name,
+                         long long *dest);
+
 #ifdef __cplusplus
 }
 #endif

lib/common/xml_element.c

@@ -1423,37 +1423,6 @@ pcmk__xe_get_timeval(const xmlNode *xml, const char *sec_attr,
     return pcmk_rc_ok;
 }
 
-/*!
- * \brief Retrieve the long long integer value of an XML attribute
- *
- * This is like \c crm_element_value() but getting the value as a long long int.
- *
- * \param[in]  data  XML node to check
- * \param[in]  name  Attribute name to check
- * \param[out] dest  Where to store element value
- *
- * \return 0 on success, -1 otherwise
- */
-int
-crm_element_value_ll(const xmlNode *data, const char *name, long long *dest)
-{
-    const char *value = NULL;
-
-    CRM_CHECK(dest != NULL, return -1);
-    value = crm_element_value(data, name);
-    if (value != NULL) {
-        int rc = pcmk__scan_ll(value, dest, PCMK__PARSE_INT_DEFAULT);
-
-        if (rc == pcmk_rc_ok) {
-            return 0;
-        }
-        crm_warn("Using default for %s "
-                 "because '%s' is not a valid integer: %s",
-                 name, value, pcmk_rc_str(rc));
-    }
-    return -1;
-}
-
 /*!
  * \internal
  * \brief Get a date/time object from an XML attribute value
@@ -1648,6 +1617,26 @@ crm_copy_xml_element(const xmlNode *obj1, xmlNode *obj2, const char *element)
     return value;
 }
 
+int
+crm_element_value_ll(const xmlNode *data, const char *name, long long *dest)
+{
+    const char *value = NULL;
+
+    CRM_CHECK(dest != NULL, return -1);
+    value = crm_element_value(data, name);
+    if (value != NULL) {
+        int rc = pcmk__scan_ll(value, dest, PCMK__PARSE_INT_DEFAULT);
+
+        if (rc == pcmk_rc_ok) {
+            return 0;
+        }
+        crm_warn("Using default for %s "
+                 "because '%s' is not a valid integer: %s",
+                 name, value, pcmk_rc_str(rc));
+    }
+    return -1;
+}
+
 int
 crm_element_value_timeval(const xmlNode *xml, const char *name_sec,
                           const char *name_usec, struct timeval *dest)