chore(core): bump Rust toolchain to 1.95.0#35665
Merged
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit b2e1d92
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
May 12, 2026
polygraph-snapshot-app Bot
pushed a commit
that referenced
this pull request
May 13, 2026
## Current Behavior `rust-toolchain.toml` pins Rust to `1.94.0`. This blocks upgrading `sysinfo` to `0.39.x`, which requires Rust `1.95` and brings upstream support for several cgroup limit features that nx currently needs to implement locally. ## Expected Behavior Toolchain bumped to `1.95.0`. Verified: - `cargo build -p nx` produces zero new warnings vs. 1.94. - `cargo build -p nx --all-targets` (compiles tests too) produces zero new warnings vs. 1.94 — identical warning set. - Clippy delta: +11 new clippy lints (style suggestions only — not gating, none correctness-related). ## Related Issue(s) N/A — maintenance/hygiene change. Unblocks the sysinfo bump that, in turn, lets PR #35622 drop its memory-side cgroup parsing in favor of upstream `Process::cgroup_limits()` + parent cgroup memory walking (sysinfo PRs [#1643](GuillaumeGomez/sysinfo#1643) and [#1651](GuillaumeGomez/sysinfo#1651)).
leosvelperez
added a commit
that referenced
this pull request
May 15, 2026
Completes the toolchain bump from #35665, which updated rust-toolchain.toml to 1.95.0 but left mise.toml at 1.90.0. CI installs rust via mise (sets RUSTUP_TOOLCHAIN, overriding rust-toolchain.toml), so CI was still on 1.90.0 — failing the sysinfo 0.39.1 MSRV check.
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
rust-toolchain.tomlpins Rust to1.94.0. This blocks upgradingsysinfoto0.39.x, which requires Rust1.95and brings upstream support for several cgroup limit features that nx currently needs to implement locally.Expected Behavior
Toolchain bumped to
1.95.0. Verified:cargo build -p nxproduces zero new warnings vs. 1.94.cargo build -p nx --all-targets(compiles tests too) produces zero new warnings vs. 1.94 — identical warning set.Related Issue(s)
N/A — maintenance/hygiene change. Unblocks the sysinfo bump that, in turn, lets PR #35622 drop its memory-side cgroup parsing in favor of upstream
Process::cgroup_limits()+ parent cgroup memory walking (sysinfo PRs #1643 and #1651).