fix(core): do not throw when node_modules/.modules.yaml is missing#35666
Open
SAY-5 wants to merge 1 commit into
Open
fix(core): do not throw when node_modules/.modules.yaml is missing#35666SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a workspace has
pnpm-workspace.yamlbutnode_moduleswas populated by a different package manager (e.g.npm ciin CI),loadPnpmHoistedDepsDefinitionthrowsCould not find ".modules.yaml" at ..., which crashes project graph creation with an opaque stack trace.Expected Behavior
Hoisted dependency definitions are an optional optimization, so the lockfile parser falls back to an empty map and the rest of the graph resolves.
Related Issue(s)
Fixes #35635