Treat guest path surfaces as nonlocal in examples

Author: nshkrdotcom

lib/codex/examples_support.ex

@@ -113,6 +113,11 @@ defmodule Codex.ExamplesSupport do
   @spec ssh_enabled?() :: boolean()
   def ssh_enabled?, do: match?(%SSHContext{execution_surface: %ExecutionSurface{}}, context())
 
+  @spec nonlocal_path_execution_surface?() :: boolean()
+  def nonlocal_path_execution_surface? do
+    ExecutionSurface.nonlocal_path_surface?(execution_surface())
+  end
+
   @spec danger_full_access?() :: boolean()
   def danger_full_access?, do: context().example_danger_full_access == true
 
@@ -134,7 +139,7 @@ defmodule Codex.ExamplesSupport do
         cwd
 
       _ ->
-        if ssh_enabled?(), do: nil, else: File.cwd!()
+        if nonlocal_path_execution_surface?(), do: nil, else: File.cwd!()
     end
   end
 
@@ -423,7 +428,7 @@ defmodule Codex.ExamplesSupport do
 
   defp maybe_put_local_codex_path(attrs, mode) do
     cond do
-      ssh_enabled?() ->
+      nonlocal_path_execution_surface?() ->
         {:ok, maybe_put_execution_surface(attrs)}
 
       local_codex_override?(attrs) ->

test/codex/examples_support_test.exs

@@ -181,6 +181,26 @@ defmodule Codex.ExamplesSupportTest do
     end
   end
 
+  describe "path semantics readiness" do
+    test "guest-path execution surfaces suppress local example cwd defaults and local codex resolution" do
+      Process.put(
+        {ExamplesSupport, :ssh_context},
+        %ExamplesSupport.SSHContext{
+          argv: [],
+          execution_surface: %ExecutionSurface{surface_kind: :test_guest_local}
+        }
+      )
+
+      assert ExamplesSupport.nonlocal_path_execution_surface?() == true
+      assert ExamplesSupport.example_working_directory() == nil
+      assert {:ok, options} = ExamplesSupport.codex_options(%{})
+      assert options.codex_path_override == nil
+      assert options.execution_surface.surface_kind == :test_guest_local
+    after
+      Process.delete({ExamplesSupport, :ssh_context})
+    end
+  end
+
   describe "ensure_remote_working_directory/1" do
     test "skips ssh examples that need a remote cwd when none is configured" do
       assert {:ok, context} = ExamplesSupport.parse_argv(["--ssh-host", "example.internal"])