Cut over to ssh_exec execution surfaces

Author: nshkrdotcom

test/codex/app_server/connection_execution_surface_test.exs

@@ -25,7 +25,7 @@ defmodule Codex.AppServer.ConnectionExecutionSurfaceTest do
         init_timeout_ms: 500,
         process_env: AppServerSubprocess.process_env(harness),
         execution_surface: [
-          surface_kind: :static_ssh,
+          surface_kind: :ssh_exec,
           transport_options:
             FakeSSH.transport_options(fake_ssh,
               destination: "app-server.test.example",

test/codex/cli_session_test.exs

@@ -251,7 +251,7 @@ defmodule Codex.CLISessionTest do
              CLI.start(["resume", "--last"],
                codex_opts: codex_opts,
                execution_surface: [
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options:
                    FakeSSH.transport_options(fake_ssh,
                      destination: "cli-session.test.example",

test/codex/cli_test.exs

@@ -239,7 +239,7 @@ defmodule Codex.CLITest do
              CLI.run(["features", "list"],
                codex_opts: codex_opts,
                execution_surface: [
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options:
                    FakeSSH.transport_options(fake_ssh,
                      destination: "cli-run.test.example",
@@ -292,7 +292,7 @@ defmodule Codex.CLITest do
     assert {:ok, %{stdout: "remote-surface\n", success: true}} =
              CLI.run(["features", "list"],
                execution_surface: [
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options:
                    FakeSSH.transport_options(fake_ssh,
                      destination: "cli-run-effective-surface.example"

test/codex/exec/options_test.exs

@@ -9,15 +9,15 @@ defmodule Codex.Exec.OptionsTest do
     {:ok, codex_opts} =
       Options.new(%{
         execution_surface: [
-          surface_kind: :static_ssh,
+          surface_kind: :ssh_exec,
           transport_options: [destination: "exec-options.test.example", port: 2222]
         ]
       })
 
     assert {:ok, %ExecOptions{execution_surface: %ExecutionSurface{} = execution_surface}} =
              ExecOptions.new(%{codex_opts: codex_opts})
 
-    assert execution_surface.surface_kind == :static_ssh
+    assert execution_surface.surface_kind == :ssh_exec
     assert execution_surface.transport_options[:destination] == "exec-options.test.example"
   end
 
@@ -28,12 +28,12 @@ defmodule Codex.Exec.OptionsTest do
              ExecOptions.new(%{
                codex_opts: codex_opts,
                execution_surface: [
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options: [destination: "override.test.example"]
                ]
              })
 
-    assert execution_surface.surface_kind == :static_ssh
+    assert execution_surface.surface_kind == :ssh_exec
     assert execution_surface.transport_options[:destination] == "override.test.example"
   end
 end

test/codex/exec_test.exs

@@ -138,7 +138,7 @@ defmodule Codex.ExecTest do
              Exec.run("hello over ssh", %{
                codex_opts: codex_opts,
                execution_surface: [
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options:
                    FakeSSH.transport_options(fake_ssh,
                      destination: "exec.test.example",

test/codex/mcp/transport/stdio_test.exs

@@ -69,7 +69,7 @@ defmodule Codex.MCP.Transport.StdioTest do
         command: AppServerSubprocess.command_path(harness),
         env: AppServerSubprocess.process_env(harness),
         execution_surface: [
-          surface_kind: :static_ssh,
+          surface_kind: :ssh_exec,
           transport_options:
             FakeSSH.transport_options(fake_ssh,
               destination: "mcp-stdio.test.example",

test/codex/options_test.exs

@@ -65,12 +65,12 @@ defmodule Codex.OptionsTest do
       assert {:ok, %Options{execution_surface: %ExecutionSurface{} = execution_surface}} =
                Options.new(%{
                  execution_surface: %{
-                   surface_kind: :static_ssh,
+                   surface_kind: :ssh_exec,
                    transport_options: [destination: "options.test.example", port: 2222]
                  }
                })
 
-      assert execution_surface.surface_kind == :static_ssh
+      assert execution_surface.surface_kind == :ssh_exec
       assert execution_surface.transport_options[:destination] == "options.test.example"
       assert execution_surface.transport_options[:port] == 2222
     end
@@ -109,7 +109,7 @@ defmodule Codex.OptionsTest do
       assert {:ok, %CliSubprocessCore.CommandSpec{program: "codex", argv_prefix: []}} =
                Options.codex_command_spec(
                  opts,
-                 surface_kind: :static_ssh,
+                 surface_kind: :ssh_exec,
                  transport_options: [destination: "ssh.example"]
                )
     end

test/codex/thread_transport_test.exs

@@ -25,22 +25,22 @@ defmodule Codex.ThreadTransportTest do
     end
 
     test "rejects execution-surface atoms in transport" do
-      assert {:error, {:invalid_transport, :static_ssh}} =
-               ThreadOptions.new(%{transport: :static_ssh})
+      assert {:error, {:invalid_transport, :ssh_exec}} =
+               ThreadOptions.new(%{transport: :ssh_exec})
     end
 
     test "rejects execution-surface maps in transport" do
-      assert {:error, {:invalid_transport, %{surface_kind: :static_ssh}}} =
-               ThreadOptions.new(%{transport: %{surface_kind: :static_ssh}})
+      assert {:error, {:invalid_transport, %{surface_kind: :ssh_exec}}} =
+               ThreadOptions.new(%{transport: %{surface_kind: :ssh_exec}})
     end
 
     test "rejects execution-surface keywords in transport" do
       assert {:error,
               {:invalid_transport,
-               [surface_kind: :static_ssh, transport_options: [destination: "example"]]}} =
+               [surface_kind: :ssh_exec, transport_options: [destination: "example"]]}} =
                ThreadOptions.new(%{
                  transport: [
-                   surface_kind: :static_ssh,
+                   surface_kind: :ssh_exec,
                    transport_options: [destination: "example"]
                  ]
                })