Stabilize plugin authoring temp directory tests

Author: nshkrdotcom

test/codex/plugins/marketplace_test.exs

@@ -3,6 +3,7 @@ defmodule Codex.Plugins.MarketplaceTest do
 
   alias Codex.Plugins
   alias Codex.Plugins.Marketplace
+  alias Codex.TestSupport.TempDir
 
   test "minimal valid marketplace parses nested policy fields and preserves unknown fields" do
     payload = %{
@@ -98,7 +99,10 @@ defmodule Codex.Plugins.MarketplaceTest do
   end
 
   test "marketplace source paths must stay inside the marketplace root" do
-    temp_root = temp_root("marketplace_containment")
+    temp_root =
+      TempDir.create!("marketplace_containment")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     marketplace_path = Path.join([temp_root, "repo", ".agents", "plugins", "marketplace.json"])
 
     File.mkdir_p!(Path.dirname(marketplace_path))
@@ -133,7 +137,10 @@ defmodule Codex.Plugins.MarketplaceTest do
   end
 
   test "marketplace source paths reject traversal segments even when they remain under the root" do
-    temp_root = temp_root("marketplace_traversal")
+    temp_root =
+      TempDir.create!("marketplace_traversal")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     marketplace_path = Path.join([temp_root, "repo", ".agents", "plugins", "marketplace.json"])
 
     File.mkdir_p!(Path.dirname(marketplace_path))
@@ -166,8 +173,4 @@ defmodule Codex.Plugins.MarketplaceTest do
              %{source_path: "./plugins/demo-plugin/../other-plugin", path: ^marketplace_path}}} =
              Plugins.read_marketplace(marketplace_path)
   end
-
-  defp temp_root(prefix) do
-    Path.join(System.tmp_dir!(), "#{prefix}_#{System.unique_integer([:positive])}")
-  end
 end

test/codex/plugins/paths_test.exs

@@ -2,9 +2,13 @@ defmodule Codex.Plugins.PathsTest do
   use ExUnit.Case, async: true
 
   alias Codex.Plugins.Paths
+  alias Codex.TestSupport.TempDir
 
   test "repo and personal scopes resolve the correct roots and canonical file paths" do
-    temp_root = temp_root("plugin_paths")
+    temp_root =
+      TempDir.create!("plugin_paths")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     repo_root = Path.join(temp_root, "repo")
     nested = Path.join(repo_root, "apps/demo")
     home_root = Path.join(temp_root, "home")
@@ -33,8 +37,4 @@ defmodule Codex.Plugins.PathsTest do
     assert {:ok, ^expected_personal_marketplace_path} =
              Paths.marketplace_path(:personal, home: home_root)
   end
-
-  defp temp_root(prefix) do
-    Path.join(System.tmp_dir!(), "#{prefix}_#{System.unique_integer([:positive])}")
-  end
 end

test/codex/plugins/scaffold_test.exs

@@ -2,9 +2,13 @@ defmodule Codex.Plugins.ScaffoldTest do
   use ExUnit.Case, async: true
 
   alias Codex.Plugins
+  alias Codex.TestSupport.TempDir
 
   test "repo-scope scaffold creates the minimal plugin tree and optional marketplace entry" do
-    temp_root = temp_root("plugin_scaffold_repo")
+    temp_root =
+      TempDir.create!("plugin_scaffold_repo")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     repo_root = Path.join(temp_root, "repo")
 
     File.mkdir_p!(Path.join(repo_root, ".git"))
@@ -41,7 +45,10 @@ defmodule Codex.Plugins.ScaffoldTest do
   end
 
   test "personal-scope scaffold resolves to the home-local plugin and marketplace roots" do
-    temp_root = temp_root("plugin_scaffold_personal")
+    temp_root =
+      TempDir.create!("plugin_scaffold_personal")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     home_root = Path.join(temp_root, "home")
     File.mkdir_p!(home_root)
 
@@ -58,12 +65,4 @@ defmodule Codex.Plugins.ScaffoldTest do
     assert File.regular?(result.manifest_path)
     assert File.regular?(result.marketplace_path)
   end
-
-  defp temp_root(prefix) do
-    Path.join(System.tmp_dir!(), "#{prefix}_#{unique_suffix()}")
-  end
-
-  defp unique_suffix do
-    Base.encode16(:crypto.strong_rand_bytes(8), case: :lower)
-  end
 end

test/codex/plugins/writer_test.exs

@@ -2,9 +2,13 @@ defmodule Codex.Plugins.WriterTest do
   use ExUnit.Case, async: true
 
   alias Codex.Plugins
+  alias Codex.TestSupport.TempDir
 
   test "manifest writes are deterministic, pretty, and newline terminated" do
-    temp_root = temp_root("plugin_writer_manifest")
+    temp_root =
+      TempDir.create!("plugin_writer_manifest")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     manifest_path = Path.join([temp_root, "demo-plugin", ".codex-plugin", "plugin.json"])
 
     {:ok, manifest} =
@@ -27,7 +31,10 @@ defmodule Codex.Plugins.WriterTest do
   end
 
   test "overwrite protection prevents silent clobbering" do
-    temp_root = temp_root("plugin_writer_overwrite")
+    temp_root =
+      TempDir.create!("plugin_writer_overwrite")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     manifest_path = Path.join([temp_root, "demo-plugin", ".codex-plugin", "plugin.json"])
 
     File.mkdir_p!(Path.dirname(manifest_path))
@@ -40,7 +47,10 @@ defmodule Codex.Plugins.WriterTest do
   end
 
   test "marketplace updates merge new plugins without erasing unrelated entries" do
-    temp_root = temp_root("plugin_writer_marketplace")
+    temp_root =
+      TempDir.create!("plugin_writer_marketplace")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     repo_root = Path.join(temp_root, "repo")
     marketplace_path = Path.join(repo_root, ".agents/plugins/marketplace.json")
 
@@ -89,7 +99,10 @@ defmodule Codex.Plugins.WriterTest do
   end
 
   test "overwrite updates preserve unknown fields on the replaced marketplace entry" do
-    temp_root = temp_root("plugin_writer_overwrite_preserve")
+    temp_root =
+      TempDir.create!("plugin_writer_overwrite_preserve")
+      |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
     repo_root = Path.join(temp_root, "repo")
     marketplace_path = Path.join(repo_root, ".agents/plugins/marketplace.json")
 
@@ -157,12 +170,4 @@ defmodule Codex.Plugins.WriterTest do
              }
            ] = marketplace.plugins
   end
-
-  defp temp_root(prefix) do
-    Path.join(System.tmp_dir!(), "#{prefix}_#{unique_suffix()}")
-  end
-
-  defp unique_suffix do
-    Base.encode16(:crypto.strong_rand_bytes(8), case: :lower)
-  end
 end

test/integration/plugin_authoring_verification_test.exs

@@ -6,6 +6,7 @@ defmodule Codex.Integration.PluginAuthoringVerificationTest do
   alias Codex.Options
   alias Codex.Plugins
   alias Codex.Protocol.Plugin
+  alias Codex.TestSupport.TempDir
 
   @moduletag :integration
 
@@ -15,7 +16,10 @@ defmodule Codex.Integration.PluginAuthoringVerificationTest do
         :ok
 
       {:ok, codex_opts} ->
-        temp_root = temp_root("plugin_authoring_verification")
+        temp_root =
+          TempDir.create!("plugin_authoring_verification")
+          |> tap(&on_exit(fn -> File.rm_rf!(&1) end))
+
         repo_root = Path.join(temp_root, "repo")
         home_root = Path.join(temp_root, "home")
         codex_home = Path.join(home_root, ".codex")
@@ -97,10 +101,6 @@ defmodule Codex.Integration.PluginAuthoringVerificationTest do
     end
   end
 
-  defp temp_root(prefix) do
-    Path.join(System.tmp_dir!(), "#{prefix}_#{System.unique_integer([:positive])}")
-  end
-
   defp run_command_spec(%CommandSpec{} = spec, args) when is_list(args) do
     System.cmd(spec.program, CommandSpec.command_args(spec, args), stderr_to_stdout: true)
   end

test/support/temp_dir.ex

@@ -0,0 +1,44 @@
+defmodule Codex.TestSupport.TempDir do
+  @moduledoc false
+
+  @max_attempts 32
+
+  def create!(prefix) when is_binary(prefix) do
+    prefix
+    |> sanitize_prefix()
+    |> create_unique!(@max_attempts)
+  end
+
+  defp create_unique!(_prefix, 0) do
+    raise "unable to allocate a unique temporary directory"
+  end
+
+  defp create_unique!(prefix, attempts_left) when attempts_left > 0 do
+    path = Path.join(System.tmp_dir!(), "#{prefix}_#{unique_suffix()}")
+
+    case File.mkdir(path) do
+      :ok ->
+        path
+
+      {:error, :eexist} ->
+        create_unique!(prefix, attempts_left - 1)
+
+      {:error, reason} ->
+        raise "unable to create temporary directory #{inspect(path)}: #{inspect(reason)}"
+    end
+  end
+
+  defp sanitize_prefix(prefix) do
+    prefix
+    |> String.trim()
+    |> String.replace(~r/[^a-zA-Z0-9_-]+/, "_")
+    |> case do
+      "" -> "codex_tmp"
+      sanitized -> sanitized
+    end
+  end
+
+  defp unique_suffix do
+    Base.encode16(:crypto.strong_rand_bytes(10), case: :lower)
+  end
+end

test/test_helper.exs

@@ -4,6 +4,7 @@ Code.require_file("support/fixture_scripts.ex", __DIR__)
 Code.require_file("support/parity_matrix.ex", __DIR__)
 Code.require_file("support/mock_websocket.ex", __DIR__)
 Code.require_file("support/model_fixtures.ex", __DIR__)
+Code.require_file("support/temp_dir.ex", __DIR__)
 
 loopback_available? =
   case :gen_tcp.listen(0, [:binary, active: false, reuseaddr: true, ip: {127, 0, 0, 1}]) do