Integration with Uproot #46
Conversation
…ties on UprootModelAdapter
inheriting values while adapting underscored naming convention
|
@nsmith- do you think this PR is in a relatively good state to be merged? I can take care of cleaning up and resolving conflicts. I want to start thinking of integrating with Uproot so that Samantha and I don't keep working in parallel on RNTuple stuff. Since things were not quite finished last summer, my plan is to start using rootfilespec for RNTuple and simple classes, and then over time move things over until everything is delegated here. |
|
Yes after some merge conflict cleanup. I will try to do that soon |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 91.32% 88.00% -3.33%
==========================================
Files 36 37 +1
Lines 2722 2826 +104
==========================================
+ Hits 2486 2487 +1
- Misses 236 339 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsmith-
left a comment
nsmith-
left a comment
There was a problem hiding this comment.
Note: this goes along with scikit-hep/uproot5#1474
Some patching will need to be done on that side as well.
| if isinstance(value, TString): | ||
| return value.fString.decode("utf-8") | ||
|
|
||
| adapter_cls = create_adapter_class(type(value)) |
There was a problem hiding this comment.
In this context, type(value) is a rootfilespec type but create_adapter_class expects the uproot model. We need instead to find the appropriate class type of a member in uproot and then use that to wrap the rootfilespec type.
4 participants
No description provided.