From 30ef3e92d65ec1f96aa5f7b75511bd2aed076e01 Mon Sep 17 00:00:00 2001 From: Edgar Asatryan Date: Tue, 17 Mar 2026 12:52:53 +0400 Subject: [PATCH] feat: The `Arity.of(int, int)` return `NAry` when arguments are the same. --- .../cz/jirutka/rsql/parser/ast/Arity.java | 2 +- .../jirutka/rsql/parser/ast/AritySpec.groovy | 41 +++++++++++++++++++ 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 src/test/groovy/cz/jirutka/rsql/parser/ast/AritySpec.groovy diff --git a/src/main/java/cz/jirutka/rsql/parser/ast/Arity.java b/src/main/java/cz/jirutka/rsql/parser/ast/Arity.java index 5d6c9eed..2af5f2ee 100644 --- a/src/main/java/cz/jirutka/rsql/parser/ast/Arity.java +++ b/src/main/java/cz/jirutka/rsql/parser/ast/Arity.java @@ -55,7 +55,7 @@ public interface Arity { * @return the created arity */ static Arity of(int min, int max) { - return new DynamicArity(min, max); + return min == max ? nary(min) : new DynamicArity(min, max); } /** diff --git a/src/test/groovy/cz/jirutka/rsql/parser/ast/AritySpec.groovy b/src/test/groovy/cz/jirutka/rsql/parser/ast/AritySpec.groovy new file mode 100644 index 00000000..bee74559 --- /dev/null +++ b/src/test/groovy/cz/jirutka/rsql/parser/ast/AritySpec.groovy @@ -0,0 +1,41 @@ +/* + * The MIT License + * + * Copyright 2026 Edgar Asatryan . + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ +package cz.jirutka.rsql.parser.ast + +import spock.lang.Specification + +class AritySpec extends Specification { + def 'should create N-ary object of arguments are equal'() { + given: + def n = 1 + + when: + def actual = Arity.of(n, n) + + then: + actual instanceof NAry + actual.min() == n + actual.max() == n + } +}