SDP profile update and minor changes

Author: ntanis-dev

README.md

@@ -100,7 +100,7 @@ You are able to configure the behavior of some of them via their settings.
   Map this button to any supported Spotify URL and press it to start playing.
 
 - **Add to Playlist**\
-  Adds the currently playing song to a selected playlist. Choose your playlist from the settings and optionally display the playlist name and/or song name with automatic scrolling for long text.
+  Adds the currently playing song to a selected playlist of yours.
 
 ### Dials
 - **Playback Control**\

com.ntanis.essentials-for-spotify.sdPlugin/SDP.streamDeckProfile

@@ -232,7 +232,7 @@
 			"Name": "Add to Playlist",
 			"UUID": "com.ntanis.essentials-for-spotify.add-to-playlist-button",
 			"Icon": "images/actions/add-to-playlist",
-			"Tooltip": "Adds the currently playing song to a specific playlist.",
+			"Tooltip": "Adds the currently playing song to a selected playlist of yours.",
 			"PropertyInspectorPath": "pi/add-to-playlist-button.html",
 			"DisableAutomaticStates": true,
 			"UserTitleEnabled": false,

com.ntanis.essentials-for-spotify.sdPlugin/manifest.json

@@ -48,84 +48,62 @@ export default class AddToPlaylistButton extends Button {
 		const show = this.settings[context].show || ['playlist']
 		const data: any = []
 
-		// Track if we need to restart marquee or just update entries
 		let needsRestart = !this.marquees[context]
 
-		for (const item of show) {
-			if (item === 'playlist' && this.settings[context].playlist_name) {
+		for (const item of show)
+			if (item === 'playlist' && this.settings[context].playlist_name)
 				data.push({
 					key: 'playlist',
 					value: this.settings[context].playlist_name
 				})
-			} else if (item === 'name' && song?.item?.name) {
+			else if (item === 'name' && song?.item?.name) {
 				data.push({
 					key: 'name',
 					value: song.item.name
 				})
 
-				// Update song marquee entry if it exists and song changed
-				if (this.marquees[context]?.entries?.name && this.marquees[context].entries.name.original !== song.item.name) {
+				if (this.marquees[context]?.entries?.name && this.marquees[context].entries.name.original !== song.item.name)
 					this.updateMarqueeEntry(context, 'name', song.item.name)
-				}
 			}
-		}
 
-		// If no data, clear the marquee and show blank
 		if (data.length === 0) {
 			this.clearMarquee(context)
 			await this.setTitle(context, '')
-			return
-		}
-
-		// Only restart marquee if needed
-		if (needsRestart || !this.marquees[context]) {
+		} else if (needsRestart || (!this.marquees[context]))
 			await this.marqueeTitle('add-to-playlist', data, context)
-		}
 	}
 
 	async #updatePlaylists(contexts = this.contexts) {
 		const items: any = []
 
-		if (connector.set) {
+		if (connector.set)
 			try {
-				// Fetch all pages of playlists
 				let page = 1
-				let hasMore = true
 
-				while (hasMore) {
+				while (true) {
 					const playlistsResponse = await wrapper.getUserPlaylists(page)
 
 					if (playlistsResponse && playlistsResponse.status === constants.WRAPPER_RESPONSE_SUCCESS) {
-						for (const playlist of playlistsResponse.items) {
+						for (const playlist of playlistsResponse.items)
 							if (playlist) {
-								// Include "Liked Songs" or playlists the user owns or collaborative playlists
-								const canAddTracks = playlist.type === 'collection' ||
-									playlist.owner?.id === wrapper.user?.id ||
-									playlist.collaborative === true
+								const canAddTracks = playlist.type === 'collection' || playlist.owner?.id === wrapper.user?.id || playlist.collaborative === true
 
-								if (canAddTracks) {
+								if (canAddTracks)
 									items.push({
 										value: playlist.id,
 										label: playlist.name
 									})
-								}
 							}
-						}
 
-						// Check if there are more pages
-						const totalFetched = page * constants.WRAPPER_ITEMS_PER_PAGE
-						hasMore = totalFetched < playlistsResponse.total
+						if ((page * constants.WRAPPER_ITEMS_PER_PAGE) >= playlistsResponse.total)
+							break
+
 						page++
-					} else {
-						hasMore = false
-					}
+					} else
+						break
 				}
-			} catch (e) {
-				// Silently handle error, will send empty array
-			}
-		}
+			} catch (e) { }
 
-		// Always send response to clear loading state
 		for (const context of contexts) {
 			await StreamDeck.client.sendToPropertyInspector(context, {
 				event: 'getPlaylists',
@@ -142,10 +120,8 @@ export default class AddToPlaylistButton extends Button {
 						playlist_name: playlist.label
 					})
 
-					// Update marquee entry if playlist name changed
-					if (oldPlaylistName !== playlist.label) {
+					if (oldPlaylistName !== playlist.label)
 						this.updateMarqueeEntry(context, 'playlist', playlist.label)
-					}
 				}
 			}
 		}
@@ -158,11 +134,9 @@ export default class AddToPlaylistButton extends Button {
 		if (!this.settings[context].playlist_id)
 			return constants.WRAPPER_RESPONSE_NOT_AVAILABLE
 
-		// Get the current track in real-time to avoid stale cached data
 		const currentTrack = await wrapper.getCurrentTrack()
 
 		if (!currentTrack?.uri) {
-			// Fall back to cached song if getCurrentTrack fails
 			if (!wrapper.song?.item?.id)
 				return constants.WRAPPER_RESPONSE_NOT_AVAILABLE
 
@@ -190,7 +164,6 @@ export default class AddToPlaylistButton extends Button {
 	async onSettingsUpdated(context: string, oldSettings: any) {
 		await super.onSettingsUpdated(context, oldSettings)
 
-		// Set default show value
 		if (!this.settings[context].show)
 			await this.setSettings(context, {
 				show: ['playlist']
@@ -199,23 +172,20 @@ export default class AddToPlaylistButton extends Button {
 		if (oldSettings.playlist_id !== this.settings[context].playlist_id)
 			await this.#updatePlaylists([context])
 
-		// Update display if show settings changed
-		const showChanged = oldSettings.show?.length !== this.settings[context].show?.length ||
-			(oldSettings.show && this.settings[context].show &&
-			(!oldSettings.show.every((value: any, index: number) => value === this.settings[context].show[index])))
+		const showChanged = oldSettings.show?.length !== this.settings[context].show?.length || (oldSettings.show && this.settings[context].show && (!oldSettings.show.every((value: any, index: number) => value === this.settings[context].show[index])))
 
 		if (showChanged) {
 			this.clearMarquee(context)
+
 			if (wrapper.song)
 				await this.#updateDisplay(context, wrapper.song)
 			else
 				await this.#updateDisplay(context, null)
-		} else if (oldSettings.playlist_id !== this.settings[context].playlist_id) {
+		} else if (oldSettings.playlist_id !== this.settings[context].playlist_id)
 			if (wrapper.song)
 				await this.#onSongChanged(wrapper.song, false)
 			else
 				await this.#onSongChanged(null, false)
-		}
 	}
 
 	async onStateSettled(context: string) {
@@ -226,9 +196,8 @@ export default class AddToPlaylistButton extends Button {
 			await this.setImage(context, 'images/states/add-to-playlist')
 			this.setUnpressable(context, false)
 			await this.#updateDisplay(context, wrapper.song)
-		} else {
+		} else
 			await this.#onSongChanged(null, false)
-		}
 	}
 
 	async onStateLoss(context: string) {

src/actions/add-to-playlist-button.ts

@@ -29,19 +29,15 @@ export default class ContextInformationButton extends Button {
 	}
 
 	async #onSongChanged(song: any, pending: boolean = false) {
-		// Only update image when image_source is set to 'album'
-		for (const context of this.contexts) {
-			if (this.settings[context]?.image_source === 'album' && wrapper.playbackContext) {
+		for (const context of this.contexts)
+			if (this.settings[context]?.image_source === 'album' && wrapper.playbackContext)
 				await this.#updateImage(context, wrapper.playbackContext, song, pending)
-			}
-		}
 	}
 
 	async #updateImage(context: string, playbackContext: any, song: any, pending: boolean) {
 		const imageSource = this.settings[context]?.image_source || 'context'
 
 		if (imageSource === 'album' && song?.item?.album) {
-			// Use album image - leverage the song cache which already has the album cover
 			if (!images.isSongCached(song))
 				await this.setImage(context, 'images/states/pending')
 
@@ -53,25 +49,22 @@ export default class ContextInformationButton extends Button {
 				await this.setImage(context, 'images/states/local')
 			else
 				await this.setImage(context)
-		} else {
-			// Use context image (original behavior)
-			if (playbackContext) {
-				if (!images.isItemCached(playbackContext))
-					await this.setImage(context, 'images/states/pending')
+		} else if (playbackContext) {
+			if (!images.isItemCached(playbackContext))
+				await this.setImage(context, 'images/states/pending')
 
-				const image = await images.getForItem(playbackContext)
+			const image = await images.getForItem(playbackContext)
 
-				if (image)
-					await this.setImage(context, `data:image/jpeg;base64,${image}`)
-				else if (playbackContext.type === 'local')
-					await this.setImage(context, 'images/states/local')
-				else
-					await this.setImage(context)
-			} else if (pending)
-				await this.setImage(context, 'images/states/pending')
+			if (image)
+				await this.setImage(context, `data:image/jpeg;base64,${image}`)
+			else if (playbackContext.type === 'local')
+				await this.setImage(context, 'images/states/local')
 			else
-				await this.setImage(context, 'images/states/context-information-unknown')
-		}
+				await this.setImage(context)
+		} else if (pending)
+			await this.setImage(context, 'images/states/pending')
+		else
+			await this.setImage(context, 'images/states/context-information-unknown')
 	}
 
 	async #onPlaybackContextChanged(playbackContext: any, pending: boolean = false, contexts = this.contexts, force = false) {
@@ -174,7 +167,6 @@ export default class ContextInformationButton extends Button {
 		if (oldSettings.show?.length !== this.settings[context].show?.length || (oldSettings.show && this.settings[context].show && (!oldSettings.show.every((value: any, index: number) => value === this.settings[context].show[index]))))
 			await this.#onPlaybackContextChanged(wrapper.playbackContext, wrapper.pendingPlaybackContext, [context], true)
 
-		// Update image when image_source changes
 		if (oldSettings.image_source !== this.settings[context].image_source && wrapper.playbackContext)
 			await this.#updateImage(context, wrapper.playbackContext, wrapper.song, wrapper.pendingPlaybackContext)
 	}

src/actions/context-information-button.ts

@@ -13,7 +13,7 @@ import {
 	v4
 } from 'uuid'
 
-const proxyAgent = false ? new ProxyAgent({
+const proxyAgent = true ? new ProxyAgent({
 	uri: 'http://127.0.0.1:8000',
 
 	requestTls: {

src/library/connector.js

@@ -13,7 +13,7 @@
     </sdpi-item>
     <sdpi-item label="Image Source">
         <sdpi-select setting="image_source">
-            <option value="context">Context (Playlist/Album/etc)</option>
+            <option value="context">Current Context (Playlist / Album)</option>
             <option value="album">Current Song's Album</option>
         </sdpi-select>
     </sdpi-item>