Update atomdict#266
Open
frmdstryr wants to merge 1 commit intonucleic:mainfrom
Open
Conversation
cfac883 to
debdfa2
Compare
Member
|
Out of curiosity do you have a use case for this coercion of the key before access ? I agree it is correct but it feels unfortunate. I wonder if we should validate only if the key is not found to avoid the performance hit. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 24 24
Lines 1093 1093
Branches 167 167
=======================================
Hits 1066 1066
Misses 13 13
Partials 14 14 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've never used it no. |
Contributor
Author
|
It could do an unvalidated key lookup first, if it fails, lookup then do what is it does in this pr? Or do you have another idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validates the key before use in AtomDict_setdefault and DefaultAtomDict_missing to avoid the unlikely yet possible case where the key is coerced which would cause the second lookup to return null.
It also corrects the bases argument as described in the recent code review, checks for unicode decode errors in DefaultDict_repr, cleans up some outdated version guards, and changes DefaultAtomDict_missing to METH_O.