Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Adds users todo, adds enforcer auto load policy for syncing#3415

Merged
nickzelei merged 1 commit intomainfrom
nick/adds-rbac-autoload
Mar 27, 2025
Merged

Adds users todo, adds enforcer auto load policy for syncing#3415
nickzelei merged 1 commit intomainfrom
nick/adds-rbac-autoload

Conversation

@nickzelei
Copy link
Copy Markdown
Member

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Mar 27, 2025 2:14am

return nil, err
}

// todo: need to re-upsert rbac for the new personal account.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEOS-1795

@nickzelei nickzelei added the bug Something isn't working label Mar 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.38%. Comparing base (a40c5ef) to head (a56ce05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/ee/rbac/enforcer/enforcer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3415      +/-   ##
==========================================
- Coverage   24.38%   24.38%   -0.01%     
==========================================
  Files         417      417              
  Lines       49351    49352       +1     
==========================================
  Hits        12036    12036              
- Misses      36177    36178       +1     
  Partials     1138     1138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Benchstat Geomean Results

-3.36% sec/op, -0.02% B/op, 0.53% allocs/op

Benchstat results
                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │       sec/op       │    sec/op     vs base               │
CleanPostgresType-4                         42.63n ± 4%    42.26n ± 4%        ~ (p=0.221 n=6)
Runner_Single-4                             7.713µ ± 5%    7.668µ ± 2%        ~ (p=0.180 n=6)
GenerateBool-4                              11.45n ± 1%    11.62n ± 2%   +1.53% (p=0.017 n=6)
GenerateBusinessName-4                      285.4n ± 0%    295.7n ± 2%   +3.61% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%    27.31n ± 0%   -3.85% (p=0.002 n=6)
GenerateCategorical-4                      104.10n ± 2%    93.39n ± 0%  -10.29% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%    170.1n ± 0%   -2.04% (p=0.002 n=6)
GenerateCountry-4                          105.20n ± 1%    97.03n ± 0%   -7.76% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%    1.295µ ± 1%   -3.79% (p=0.002 n=6)
GenerateFirstName-4                         203.9n ± 0%    196.7n ± 1%   -3.53% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%    26.68n ± 0%   -7.15% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%    1.428µ ± 0%        ~ (p=0.372 n=6)
GenerateFullName-4                          1.222µ ± 1%    1.240µ ± 2%        ~ (p=0.087 n=6)
GenerateGender-4                            41.42n ± 0%    37.18n ± 1%  -10.24% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%    26.86n ± 0%   -5.46% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%    52.46n ± 0%   +1.95% (p=0.004 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%    169.4n ± 0%   -3.64% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%    552.0n ± 1%   -3.03% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%    184.8n ± 1%   -1.41% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   1023.0n ± 0%   +3.79% (p=0.002 n=6)
GenerateSHA256Hash-4                       1016.5n ± 0%    997.1n ± 1%   -1.91% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%    269.7n ± 1%  -11.81% (p=0.002 n=6)
GenerateState-4                            105.15n ± 2%    99.60n ± 1%   -5.27% (p=0.002 n=6)
GenerateStreetAddress-4                     204.0n ± 1%    199.0n ± 0%   -2.43% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%    165.6n ± 1%   -7.64% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%    76.89n ± 2%        ~ (p=0.058 n=6)
GenerateUsername-4                          351.5n ± 0%    354.3n ± 1%   +0.81% (p=0.006 n=6)
GenerateUTCTimestamp-4                     104.25n ± 1%    99.73n ± 0%   -4.33% (p=0.002 n=6)
GenerateUUID-4                              734.0n ± 0%    732.0n ± 1%        ~ (p=0.240 n=6)
GenerateZipcode-4                          105.15n ± 2%    94.77n ± 0%   -9.87% (p=0.002 n=6)
TransformCharacterScramble-4                171.8n ± 1%    159.4n ± 2%   -7.19% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%    177.5n ± 0%   -1.47% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%    1.745µ ± 1%   -2.98% (p=0.002 n=6)
TransformFirstName-4                        233.9n ± 0%    230.5n ± 2%        ~ (p=0.061 n=6)
TransformFloat64-4                          110.8n ± 4%    101.6n ± 3%   -8.34% (p=0.002 n=6)
TransformFullName-4                         1.235µ ± 2%    1.242µ ± 2%        ~ (p=0.621 n=6)
TransformInt64-4                            33.74n ± 1%    31.60n ± 1%   -6.33% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%    59.89n ± 0%   +3.55% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%    192.5n ± 1%   +0.47% (p=0.011 n=6)
TransformString-4                           1.022µ ± 0%    1.048µ ± 0%   +2.44% (p=0.002 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%    186.6n ± 1%  -11.54% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%    32.76n ± 1%  -10.34% (p=0.002 n=6)
geomean                                     194.0n         187.5n        -3.36%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.298Ki ± 1%       ~ (p=0.058 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │     allocs/op      │  allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.500 ± 20%       ~ (p=0.182 n=6)
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ±  0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                +0.53%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei marked this pull request as ready for review March 27, 2025 02:48
@nickzelei nickzelei merged commit 06cf6da into main Mar 27, 2025
14 of 16 checks passed
@nickzelei nickzelei deleted the nick/adds-rbac-autoload branch March 27, 2025 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants