Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Clean up redis at the end of workflow#3416

Merged
alishakawaguchi merged 2 commits intomainfrom
alisha/redis-cleanup
Mar 27, 2025
Merged

Clean up redis at the end of workflow#3416
alishakawaguchi merged 2 commits intomainfrom
alisha/redis-cleanup

Conversation

@alishakawaguchi
Copy link
Copy Markdown

@alishakawaguchi alishakawaguchi commented Mar 27, 2025

No description provided.

@alishakawaguchi alishakawaguchi self-assigned this Mar 27, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2025 4:29pm

@alishakawaguchi alishakawaguchi added the bug Something isn't working label Mar 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.36%. Comparing base (a40c5ef) to head (48cad2d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
worker/pkg/workflows/datasync/workflow/workflow.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
- Coverage   24.38%   24.36%   -0.02%     
==========================================
  Files         417      417              
  Lines       49351    49317      -34     
==========================================
- Hits        12036    12018      -18     
+ Misses      36177    36165      -12     
+ Partials     1138     1134       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2025 •
edited
Loading

Benchstat Geomean Results

-3.82% sec/op, -0.04% B/op, 0.97% allocs/op

Benchstat results 
                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │       sec/op       │    sec/op      vs base               │
CleanPostgresType-4                         42.63n ± 4%    42.80n ±  5%        ~ (p=0.372 n=6)
Runner_Single-4                             7.713µ ± 5%    7.493µ ± 10%        ~ (p=0.065 n=6)
GenerateBool-4                              11.45n ± 1%    11.66n ±  1%   +1.83% (p=0.011 n=6)
GenerateBusinessName-4                      285.4n ± 0%    275.1n ±  7%        ~ (p=0.065 n=6)
GenerateCardNumber-4                        28.41n ± 1%    27.25n ±  1%   -4.05% (p=0.002 n=6)
GenerateCategorical-4                      104.10n ± 2%    92.97n ±  1%  -10.70% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%    170.0n ±  0%   -2.13% (p=0.002 n=6)
GenerateCountry-4                          105.20n ± 1%    96.87n ±  0%   -7.92% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%    1.296µ ±  0%   -3.71% (p=0.002 n=6)
GenerateFirstName-4                         203.9n ± 0%    199.8n ±  0%   -2.04% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%    26.73n ±  0%   -6.99% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%    1.420µ ±  1%   -0.66% (p=0.017 n=6)
GenerateFullName-4                          1.222µ ± 1%    1.206µ ±  1%   -1.27% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%    37.04n ±  0%  -10.57% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%    26.73n ±  0%   -5.88% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%    52.40n ±  1%   +1.84% (p=0.015 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%    168.8n ±  1%   -3.98% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%    548.1n ±  1%   -3.72% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%    185.0n ±  0%   -1.31% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   1020.0n ±  0%   +3.49% (p=0.002 n=6)
GenerateSHA256Hash-4                       1016.5n ± 0%    990.9n ±  1%   -2.51% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%    268.9n ±  1%  -12.07% (p=0.002 n=6)
GenerateState-4                            105.15n ± 2%    99.37n ±  0%   -5.50% (p=0.002 n=6)
GenerateStreetAddress-4                     204.0n ± 1%    197.6n ±  0%   -3.11% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%    165.1n ±  4%   -7.95% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%    76.53n ±  1%   -0.77% (p=0.015 n=6)
GenerateUsername-4                          351.5n ± 0%    349.8n ±  0%   -0.47% (p=0.002 n=6)
GenerateUTCTimestamp-4                     104.25n ± 1%    99.86n ±  1%   -4.21% (p=0.002 n=6)
GenerateUUID-4                              734.0n ± 0%    733.0n ±  1%        ~ (p=0.619 n=6)
GenerateZipcode-4                          105.15n ± 2%    94.44n ±  1%  -10.18% (p=0.002 n=6)
TransformCharacterScramble-4                171.8n ± 1%    159.2n ±  1%   -7.31% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%    177.3n ±  0%   -1.61% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%    1.738µ ±  0%   -3.34% (p=0.002 n=6)
TransformFirstName-4                        233.9n ± 0%    233.4n ±  0%        ~ (p=0.509 n=6)
TransformFloat64-4                          110.8n ± 4%    100.8n ±  0%   -9.07% (p=0.002 n=6)
TransformFullName-4                         1.235µ ± 2%    1.213µ ±  1%   -1.74% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%    31.56n ±  1%   -6.46% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%    59.87n ±  0%   +3.50% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%    192.8n ±  1%        ~ (p=0.097 n=6)
TransformString-4                           1.022µ ± 0%    1.048µ ±  1%   +2.44% (p=0.002 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%    185.9n ±  1%  -11.87% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%    32.68n ±  4%  -10.56% (p=0.002 n=6)
geomean                                     194.0n         186.6n         -3.82%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.274Ki ± 4%  -1.67% (p=0.009 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.04%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │     allocs/op      │  allocs/op   vs base                 │
CleanPostgresType-4                        0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ±  0%        ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     3.000 ± 33%  +50.00% (p=0.015 n=6)
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ±  0%        ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
geomean                                               ²                 +0.97%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@alishakawaguchi alishakawaguchi merged commit 252ee88 into main Mar 27, 2025
15 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/redis-cleanup branch March 27, 2025 20:40
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nickzelei nickzelei nickzelei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alishakawaguchi alishakawaguchi

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alishakawaguchi @nickzelei