Nidx: Support for S3 endpoint TLS validation option#3644
Merged
javitonino merged 5 commits intoMay 14, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3644 +/- ##
==========================================
- Coverage 85.23% 85.22% -0.01%
==========================================
Files 564 564
Lines 48508 48542 +34
Branches 14221 14255 +34
==========================================
+ Hits 41346 41371 +25
- Misses 6547 6555 +8
- Partials 615 616 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
67ffeca to
601a34f
Compare
601a34f to
63f6b63
Compare
javitonino
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring SSL certificate verification for S3-compatible object storage backends in the nidx chart and backend. It updates Helm chart values and documentation to expose the
verify_ssloption, modifies the Rust backend to pass this setting to the S3 client, and adds tests to ensure correct parsing and behavior.Helm chart and configuration improvements:
charts/nidx/README.mdandcharts/nidx/values.yamlto document and expose theverify_ssloption for both indexer and storage S3 object store configurations, allowing users to enable or disable TLS certificate verification via environment variables. [1] [2]Backend (Rust) enhancements:
verify_sslfield to theObjectStoreKind::S3variant innidx/src/settings.rs, and updated the S3 client builder to respect this setting, disabling certificate verification when requested. [1] [2] [3]Testing and reliability:
nidx/src/settings.rsto verify correct parsing of theverify_sslsetting from both JSON and environment variables, and to ensure the default behavior is to enable certificate verification. [1] [2]### DescriptionDescribe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.